Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpectedly remove useful flags in PR 7112 #45194

Closed
xzhangxian1008 opened this issue Jul 6, 2023 · 2 comments · Fixed by #45355
Closed

Unexpectedly remove useful flags in PR 7112 #45194

xzhangxian1008 opened this issue Jul 6, 2023 · 2 comments · Fixed by #45355
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@xzhangxian1008
Copy link
Contributor

Enhancement
@xzhangxian1008 xzhangxian1008 added the type/enhancement The issue or PR belongs to an enhancement. label Jul 6, 2023
@Defined2014
Copy link
Contributor

Hello, could you add some explanations for this issue?

@xzhangxian1008
Copy link
Contributor Author

Location: builtin_cast.go:1722

tp.Flag |= expr.GetType().Flag & mysql.UnsignedFlag removes the useful flag, for example, when the column is nullable, this operation will remove the column's nullable attribute.

@xzhangxian1008 xzhangxian1008 mentioned this issue Jul 14, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 14, 2023
@xzhangxian1008
expression: Add NotNullFlag in WrapWithCast* (#45355)
7105505 
close #45194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expression: Add NotNullFlag in WrapWithCast* xzhangxian1008/tidb
2 participants
@xzhangxian1008 @Defined2014