Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make placement rule in sql compatible with tiflash #37171

Closed
lcwangchao opened this issue Aug 17, 2022 · 0 comments · Fixed by #37252
Closed

Make placement rule in sql compatible with tiflash #37171

lcwangchao opened this issue Aug 17, 2022 · 0 comments · Fixed by #37252
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. type/enhancement The issue or PR belongs to an enhancement.

Comments

@lcwangchao
Copy link
Collaborator

Enhancement

Currently, the placement rule group of tiflash is 0 that can be override by rules generated by "placement in SQL", so it is why we forbid set a table's placement policy and tiflash replica at the same time.

We can make the tiflash's group index higher to fix the above problem.
@lcwangchao lcwangchao added the type/enhancement The issue or PR belongs to an enhancement. label Aug 17, 2022
@lcwangchao lcwangchao mentioned this issue Aug 17, 2022
Merged
2 tasks
ti-chi-bot pushed a commit that referenced this issue Aug 19, 2022
@lcwangchao
ddl: set tiflash placement group index to 120 (#37179)
d1f75f0 
ref #37171
@lcwangchao lcwangchao mentioned this issue Aug 22, 2022
Merged
7 tasks
ti-chi-bot pushed a commit that referenced this issue Aug 23, 2022
@lcwangchao
*: allow setting placement policy and tiflash replica at the same tim…
75e0885 
…e in one table (#37252)

close #37171
@hongyunyan hongyunyan mentioned this issue Aug 31, 2022
Merged
12 tasks
ti-chi-bot pushed a commit to pingcap/tiflash that referenced this issue Sep 2, 2022
@hongyunyan
Add rfc for feature 'placement rules in SQL works with tables with Ti…
47a4ada 
…Flash replica' (#5746)

close #5768, ref pingcap/tidb#37171
@lcwangchao lcwangchao added the affects-6.1 This bug affects the 6.1.x(LTS) versions. label Oct 14, 2022
This was referenced Oct 14, 2022
Merged
Merged
ti-chi-bot added a commit that referenced this issue Oct 14, 2022
@ti-chi-bot
ddl: set tiflash placement group index to 120 (#37179) (#38476)
544e759 
ref #37171
ti-chi-bot added a commit that referenced this issue Oct 14, 2022
@ti-chi-bot
*: allow setting placement policy and tiflash replica at the same tim…
353f482 
…e in one table (#37252) (#38477)

close #37171
lcwangchao pushed a commit to lcwangchao/tidb that referenced this issue Oct 14, 2022
@ti-chi-bot @lcwangchao
ddl: set tiflash placement group index to 120 (pingcap#37179) (pingca…
9be8759 
…p#38476)

ref pingcap#37171
lcwangchao pushed a commit to lcwangchao/tidb that referenced this issue Oct 14, 2022
@ti-chi-bot @lcwangchao
*: allow setting placement policy and tiflash replica at the same tim…
21ced07 
…e in one table (pingcap#37252) (pingcap#38477)

close pingcap#37171
@lcwangchao lcwangchao mentioned this issue Oct 14, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Oct 14, 2022
@lcwangchao
*: cherry pick #37252 #37179 (#38481)
852d31d 
ref #37171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: allow setting placement policy and tiflash replica at the same time in one table lcwangchao/tidb
1 participant
@lcwangchao