Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support from_days/to_days in TiFlash #34136

Closed
LittleFall opened this issue Apr 20, 2022 · 0 comments · Fixed by #34135
Closed

Support from_days/to_days in TiFlash #34136

LittleFall opened this issue Apr 20, 2022 · 0 comments · Fixed by #34135
Labels
type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@LittleFall
Copy link
Contributor

pingcap/tiflash#4678

Feature Request

Is your feature request related to a problem? Please describe:

Describe the feature you'd like:

Support from_days in TiFlash
MySQL doc:
https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_from-days
TiDB implementation:

func (b *builtinFromDaysSig) evalTime(row chunk.Row) (types.Time, bool, error) {

Support to_days in TiFlash
MySQL doc:
https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_to-days
TiDB implementation:
func (b *builtinToDaysSig) evalInt(row chunk.Row) (int64, bool, error) {

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant