Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test fail #19

Closed
unknwon opened this issue Sep 6, 2015 · 5 comments
Closed

Make test fail #19

unknwon opened this issue Sep 6, 2015 · 5 comments

Comments

@unknwon
Copy link
Contributor

unknwon commented Sep 6, 2015

System: Mac OS 10.10.5

Dump from console:

----------------------------------------------------------------------
FAIL: time_test.go:292: testTimeSuite.TestCodec

time_test.go:339:
    c.Assert(t.String(), Equals, t4.String())
... obtained string = "0001-01-01 00:00:00"
... expected string = "0000-12-31 23:00:00"


----------------------------------------------------------------------
FAIL: time_test.go:342: testTimeSuite.TestParseTimeFromNum

time_test.go:392:
    c.Assert(err, NotNil)
... value = nil

OOPS: 14 passed, 2 FAILED
--- FAIL: TestT (0.01s)
FAIL
coverage: 89.6% of statements

Is this a actually bug or just something wrong with test case?
@siddontang
Copy link
Member

Hi @unknwon, what's your timezone?

@unknwon
Copy link
Contributor Author

unknwon commented Sep 6, 2015

-0400 EDT

@siddontang
Copy link
Member

It seems that we don't test time fully with different timezones, we will fix it ASAP.

siddontang added a commit that referenced this issue Sep 6, 2015
@siddontang
mysqldef: fix issue #19
2e9674f
@qiuyesuifeng qiuyesuifeng mentioned this issue Sep 6, 2015
Closed
siddontang added a commit that referenced this issue Sep 6, 2015
@siddontang
Merge pull request #20 from pingcap/siddontang/fix-issue-19
a51d4c4 
mysqldef: fix issue #19
@siddontang
Copy link
Member

Hi @unknwon you can check it again. Thanks.

@unknwon
Copy link
Contributor Author

unknwon commented Sep 6, 2015

Fixed, thanks!

@unknwon unknwon closed this as completed Sep 6, 2015
spongedu pushed a commit to spongedu/tidb that referenced this issue Oct 25, 2019
@qiuyesuifeng
Merge pull request pingcap#19 from lonng/hackthon
43dd3bf 
infoschema: add virtual table cluster_config
@pingcap pingcap deleted a comment from sre-bot Jan 9, 2020
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
@holys @huachaohuang
fix analyze table (pingcap#19)
5def97a
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
@kennytm @overvenus
restore: add missing '/' to help of --connect for br restore full (p…
c73d56f 
…ingcap#19)
xhebox pushed a commit to xhebox/tidb that referenced this issue Sep 28, 2021
@zimulala
[parser] *: support for the statement of "admin show tableName next r…
889cd6a 
…ow id" (pingcap#19)
xhebox pushed a commit to xhebox/tidb that referenced this issue Oct 8, 2021
@zimulala @xhebox
[parser] *: support for the statement of "admin show tableName next r…
7f67c9f 
…ow id" (pingcap#19)
ti-chi-bot pushed a commit that referenced this issue Oct 9, 2021
@zimulala @ti-chi-bot
[parser] *: support for the statement of "admin show tableName next r…
53c43f7 
…ow id" (#19)
okJiang pushed a commit to okJiang/tidb that referenced this issue Oct 19, 2021
@tangenta @kennytm
support dumping binary data in hexadecimal representation (pingcap#19)
4bef27e 
* bugfix: make RowIter.HasNext idemponent

* add a test for rowIter

* support dumping binary data in hexadecimal representation

* address comments

* add sql_type.go

* fix bugs and typo
crazycs520 added a commit to crazycs520/tidb that referenced this issue Jan 7, 2022
@crazycs520
Merge pull request pingcap#19 from rebelice/dev_limit
7db01e9 
support limit
Defined2014 added a commit to Defined2014/tidb that referenced this issue Mar 15, 2022
@Defined2014
Check index (pingcap#19)
fcfaca6 
* check index

* ddl, parser: support check addIndex and dropIndex
ywqzzy pushed a commit to ywqzzy/tidb that referenced this issue Jul 17, 2023
@wjhuang2016
Merge pull request pingcap#19 from tangenta/new_writer-9
9d16931 
fix engine load not found bug and add system variables
guoshouyan pushed a commit to guoshouyan/tidb that referenced this issue Mar 5, 2024
@Tema @crazycs520
infoschema: refine info cache logic to reduce the impact of DDL on in…
0472bc6 
…formation schema cache pingcap#48293 (pingcap#19)

* refine info cache

Signed-off-by: crazycs520 <[email protected]>

* update

Signed-off-by: crazycs520 <[email protected]>

Signed-off-by: crazycs520 <[email protected]>
Co-authored-by: crazycs520 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@siddontang @unknwon