fix apiVersion for DaemonSet #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@nyurik Thank you for your contribution! Could you change other obsolete |
|
The |
|
I think it's OK since the minimal requirement is k8s 1.12.5. The |
|
@nyurik Hi, if you don't want to fix other obsolete apiVersion in this PR, we can merge it for now and fix others in later PRs. |
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* zh: add the docs about deploying a multicluster TiDB cluster * add tls description * remove concepts about VPC-native * modify descriptions about FQDN * modify FQDN description * experimental support description * add cluster down and recycle * fix PD member leader * fix comment about multi kubernetes clusters * revert Kubernets clusters support * fix description about multicluster * add line break * fix bare url lint err * add to toc * fix comment * seperate one expression * fix spaces in cluster name * fix namespace * fix comment * remove unused namespace metainfo * fix notice * Apply suggestions from code review Co-authored-by: DanielZhangQD <[email protected]> * fix add exsisted cluster description * fix comments * fix error * fix tls * fix comment on TLS * Update TOC * fix lint * Apply suggestions from code review Co-authored-by: Ran <[email protected]> Co-authored-by: DanielZhangQD <[email protected]> * Add components TLS introduction * fix format * add tls support * fix comma error * avoid duplicate title * fix descriptions in join clusters. * organize the structure * use ordered list to describe each step * fix order list ci * fix ci * separate env and create func * Update zh/deploy-tidb-cluster-across-multiple-kubernetes.md Co-authored-by: DanielZhangQD <[email protected]> * support scenario description update * Update zh/deploy-tidb-cluster-across-multiple-kubernetes.md Co-authored-by: DanielZhangQD <[email protected]> * Update zh/deploy-tidb-cluster-across-multiple-kubernetes.md Co-authored-by: DanielZhangQD <[email protected]> * fix namespace * fix description in CA * fix URL * fix URL * fix CI * suggest to remove unused information in cacert secret * add title for components cert issue * Apply suggestions from code review Co-authored-by: Ran <[email protected]> * Apply suggestions from code review Co-authored-by: DanielZhangQD <[email protected]> * Add copyable tag * fix comment * fix clusterdomain * Apply suggestions from code review Co-authored-by: Ran <[email protected]> * fix comment * remove mistaken step division * use kubectl patch * use patch * Apply suggestions from code review Co-authored-by: DanielZhangQD <[email protected]> * fix update peerURL * split the contents Co-authored-by: DanielZhangQD <[email protected]> Co-authored-by: Ran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
apiVersion: extensions/v1beta1has marked DaemonSet as obsolete, switching toapps/v1What is changed and how does it work?
apiVersion: extensions/v1beta1has marked DaemonSet as obsoleteCheck List
?
Does this PR introduce a user-facing change?: