Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy, manifests: enable cloud storage volume expansion & label local volume (#772) #781

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 16, 2019

cherry-pick #772 to release-1.0


What problem does this PR solve?

What is changed and how does it work?

Cloud storage volume expansion is enabled by default. Hostname label will be attached to local PV.

Check List

Tests

  • Manual test
    1. Cloud provider storage class allowVolumeExpansion attribute can be updated in-place by kubectl edit sc ebs-gp2 to add allowVolumeExpansion: true
    2. After adding allowVolumeExpansion: true, updating PVC with larger storage size, the corresponding PV will be expanded to the desired size.
    3. The storage class reclaimPolicy can not be changed dynamically. So old gke persistent disk storage class cannot migrate to Retain.

Code changes

  • Has volume setup change

Side effects

None

Related changes

  • Need to cherry-pick to the release-1.0 branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Users can now expand cloud storage PV dynamically by increasing PVC storage size.

@weekface
Copy link
Contributor

/run-e2e-in-kind

@weekface weekface merged commit d59107c into pingcap:release-1.0 Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants