improving the readability of some code #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregwebs
reviewed
Jul 5, 2019
| @@ -387,12 +387,13 @@ func (tmm *tidbMemberManager) syncTidbClusterStatus(tc *v1alpha1.TidbCluster, se | |||
| Health: health, | |||
| } | |||
| oldTidbMember, exist := tc.Status.TiDB.Members[name] | |||
|
|
|||
| newTidbMember.LastTransitionTime = metav1.Now() | |||
There was a problem hiding this comment.
This looks like a bugfix instead of just a readability change?
There was a problem hiding this comment.
Not a bugfix, the logic is still the same as before
|
/run-e2e-tests |
weekface
approved these changes
Jul 8, 2019
|
@xiaojingchen ptal |
xiaojingchen
approved these changes
Jul 8, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
… default (#639) * add debug section * comment storageClassName * fix dead anchor * address comments * address comments Co-authored-by: ti-srebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Improve the readability of the code for processing
LastTransitionTimeWhat is changed and how does it work?
Check List
Tests
Code changes
Does this PR introduce a user-facing change?: