Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support graceful upgrade TiCDC (>=6.3.0) pods #4697

Merged
merged 5 commits into from
Sep 13, 2022

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Support graceful upgrade TiCDC (>=6.3.0) pods

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • KanShiori

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #4697 (177a161) into release-1.3 (da0f4ae) will increase coverage by 10.06%.
The diff coverage is 69.03%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.3    #4697       +/-   ##
================================================
+ Coverage        62.25%   72.32%   +10.06%     
================================================
  Files              186      190        +4     
  Lines            20584    23338     +2754     
================================================
+ Hits             12815    16879     +4064     
+ Misses            6590     5268     -1322     
- Partials          1179     1191       +12     
Flag Coverage Δ
e2e 59.60% <43.87%> (?)
unittest 62.36% <66.55%> (+0.10%) ⬆️

@KanShiori
Copy link
Collaborator

/test pull-e2e-kind-basic

@csuzhangxc csuzhangxc merged commit a735acc into pingcap:release-1.3 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants