Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abandon vendor and refresh go.sum #311

Merged
merged 3 commits into from
Mar 13, 2019
Merged

Abandon vendor and refresh go.sum #311

merged 3 commits into from
Mar 13, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Mar 12, 2019

  • Abandon vendor
  • Re-generate go.sum under go 1.12 enviroment
  • Tracking tool dependencies

For IDE lacking go module support, users may generate the vendor directory using go mod vendor manually.

Signed-off-by: Aylei [email protected]

@aylei
Copy link
Contributor Author

aylei commented Mar 12, 2019

/run-e2e-tests

1 similar comment
@aylei
Copy link
Contributor Author

aylei commented Mar 12, 2019

/run-e2e-tests

@aylei
Copy link
Contributor Author

aylei commented Mar 12, 2019

/run-e2e-tests

xiaojingchen
xiaojingchen approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@xiaojingchen xiaojingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tennix
tennix approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix merged commit c3ea4b8 into pingcap:master Mar 13, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@CaitinChen
configure-tidb-binlog-drainer: fix the nodeselector links (#311)
29eca23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaojingchen xiaojingchen xiaojingchen approved these changes

@tennix tennix tennix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aylei @xiaojingchen @tennix