crd: add validation to crd #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tennix
reviewed
Oct 29, 2018
| properties: | ||
| limits: | ||
| properties: | ||
| cpu: |
There was a problem hiding this comment.
Is it necessary to add other fields validation?
There was a problem hiding this comment.
We can add additional verification if needed in the future.
|
/run-e2e-tests |
|
LGTM |
onlymellb
approved these changes
Oct 31, 2018
queenliuxx
pushed a commit
to queenliuxx/tidb-operator
that referenced
this pull request
Dec 19, 2018
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
fgksgf
pushed a commit
to fgksgf/tidb-operator
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #150 , add a validation to CRD to ensure the
cpuproperties is string.@tennix @onlymellb @xiaojingchen @gregwebs PTAL