New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.0] fix make check #1141

Merged

tennix merged 1 commit into pingcap:release-1.0 from cofyc:fix-release-1.0

Nov 13, 2019

Contributor

cofyc commented Nov 13, 2019

What problem does this PR solve?

fixes make check on release-1.0 branch

What is changed and how does it work?

Check List

Tests

Unit test
E2E test
Stability test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has Helm charts change
Has Go code change
Has CI related scripts change
Has documents change

Side effects

Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Does this PR introduce a user-facing change?:


          fix make check

4d9ab38

add github actions job

Contributor Author

cofyc commented Nov 13, 2019

/run-e2e-in-kind

1 similar comment

Contributor Author

cofyc commented Nov 13, 2019

/run-e2e-in-kind

cofyc requested review from tennix and weekface

November 13, 2019 12:30

tennix approved these changes

View reviewed changes

Member

tennix left a comment

LGTM

weekface approved these changes

View reviewed changes

tennix merged commit 85b40db into pingcap:release-1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet