tidb graceful upgrade #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaojingchen
force-pushed
the
tidb-graceful-upgrade
branch
from
15a3eaa to
a7de64c
Compare
weekface
reviewed
Oct 11, 2018
pkg/controller/tidb_control.go
Outdated
| // TiDBControlInterface is the interface that knows how to manage tidb peers | ||
| type TiDBControlInterface interface { | ||
| // GetHealth returns tidb's health info | ||
| GetHealth(tc *v1alpha1.TidbCluster) map[string]bool | ||
| // ResignDDLOwner resign the ddl owner of tidb |
pkg/controller/tidb_control.go
Outdated
| ns := tc.GetNamespace() | ||
|
|
||
| hostName := fmt.Sprintf("%s-%d", TiDBMemberName(tcName), ordinal) | ||
| url := fmt.Sprintf("http://%s.%s-tidb-peer.%s:10080/ddl/owner/resign", hostName, tcName, ns) |
There was a problem hiding this comment.
url := fmt.Sprintf("http://%s.%s.%s:10080/ddl/owner/resign", hostName, TiDBPeerMemberName(tcName), ns)
pkg/manager/member/tidb_upgrader.go
Outdated
| upgradeOrdinal := tc.Status.TiDB.StatefulSet.CurrentReplicas - 1 | ||
| if member, exist := tc.Status.TiDB.Members[tidbPodName(tc, upgradeOrdinal)]; exist && member.Health { | ||
| err := tdu.tidbControl.ResignDDLOwner(tc, upgradeOrdinal) | ||
| if err != nil && tc.Status.TiDB.ResignDDLOwnerFailCount < MaxResignDDLOwnerCount { |
There was a problem hiding this comment.
If err != nil && ResignDDLOwnerFailCount >= ResignDDLOwnerFailCount
then
this method will return nil.
This is the expected behavior？
There was a problem hiding this comment.
Until the tidb resign ddl owner fail count is more then MaxResignDDLOwnerCount , we can think the tidb is unavailable, then upgrade it; otherwise, we must continue to try
pkg/manager/member/tidb_upgrader.go
Outdated
|
|
||
| upgradeOrdinal := tc.Status.TiDB.StatefulSet.CurrentReplicas - 1 | ||
| if member, exist := tc.Status.TiDB.Members[tidbPodName(tc, upgradeOrdinal)]; exist && member.Health { | ||
| err := tdu.tidbControl.ResignDDLOwner(tc, upgradeOrdinal) |
There was a problem hiding this comment.
If the TiDB replicas is 1, you do not need to resign.
|
/run-e2e-tests |
tennix
reviewed
Oct 11, 2018
| return controller.RequeueErrorf("tidbcluster: [%s/%s]'s tidb doesn't have old version pod to upgrade", ns, tcName) | ||
| } | ||
|
|
||
| if !tc.TiDBAllPodsStarted() { |
There was a problem hiding this comment.
Do we need to wait all TiDB ready to upgrade TiDB?
|
/run-e2e-tests |
weekface
approved these changes
Oct 12, 2018
queenliuxx
pushed a commit
to queenliuxx/tidb-operator
that referenced
this pull request
Dec 19, 2018
* tidb graceful upgrade
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
fgksgf
pushed a commit
to fgksgf/tidb-operator
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR add the tidb graceful upgrade feature and fixes #89
it mainly logic is to resign ddl owner before upgrade a tidb instance