Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support post_exec on Raftstore Proxy #140

Merged
merged 60 commits into from
Aug 23, 2022
Merged

Support post_exec on Raftstore Proxy #140

merged 60 commits into from
Aug 23, 2022

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Aug 9, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref pingcap/tiflash#5170

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

CalvinNeo and others added 30 commits July 4, 2022 21:48
@CalvinNeo
f
0b7bf7f 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fix
fea5a4a 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
add engine_tiflash with this version of engine_rocks
67c47da 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fmt
c96c0c3 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Merge remote-tracking branch 'upstream/raftstore-proxy-6.2' into try-…
a3d6722 
…add-new-mock-engine-store-in-6.2
@CalvinNeo
add engine_tiflash actually
e3a716b 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fix
9bfec36 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fix some tests
5afb804 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
f
0f38d9d 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
it runs if we do_write everytime
ed1708b 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
add ensure_no_common_unrecognized_keys to config checker
8ab1acb 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
reorg tests
5237c17 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo @ti-chi-bot
raftstore: Implement coprocessor observer on_empty_cmd (tikv#12851)
4d4c583 
ref tikv#12849

Support new observers on_empty_cmd.

Signed-off-by: CalvinNeo <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
@CalvinNeo
fix tests
b147018 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
move proxy-related code in component/server into proxy_server
3d50bcc 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Merge remote-tracking branch 'upstream/raftstore-proxy-6.2' into try-…
8833251 
…add-new-mock-engine-store-in-6.2
@CalvinNeo
move codes in component/server/src/setup.rs into proxy_server
f0ad93d 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
support new ffis in mock-engine-store and new-mock-engine-store
453eb87 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
add disclaimer
573efc6 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
enlength some test time
af8b448 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Remove pub fields of PdCluster, add feature to origin import
cb5bc33 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
raftstore: Implement coprocessor observer pre_exec_admin(query) (tikv…
e8e1851 
…#12868)

ref tikv#12849

Support new observers pre_exec_admin(query).

Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
add
3dae81c 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
pf
731c57d 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Merge remote-tracking branch 'upstream/raftstore-proxy-6.2' into migr…
39c1db6 
…ate-pre-exec
@CalvinNeo
remove logs
c301334 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
remove hack: computehash/verifyhash/transferhash
f1bba4e 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo @ti-chi-bot
raftstore: Implement coprocessor observer post_exec_admin(query) (tik…
b688e40 
…v#12850)

ref tikv#12849

Support new observers post_exec_admin(query).

Signed-off-by: CalvinNeo <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
@CalvinNeo
remove rollback of CompactLog
e83a37d 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Merge branch 'migrate-pre-exec' into migrate-post-exec
a41861e
CalvinNeo
CalvinNeo commented Aug 9, 2022
View reviewed changes
components/sst_importer/src/import_file.rs
@@ -83,7 +83,8 @@ impl fmt::Debug for ImportPath {
/// ImportFile is used to handle the writing and verification of SST files.
pub struct ImportFile {
meta: SstMeta,
path: ImportPath,
// TODO(tiflash) remove pub when support get_import_path
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In tikv#13061

CalvinNeo added 10 commits August 9, 2022 20:59
@CalvinNeo
f
de8aa46 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fix old tests by default enable new proxy
b694fc7 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
raise log level
af80e62 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
disable test_early_apply_yield_followed_with_many_entries
34b3fe7 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fix tests by enabling persist on old
e44a3d1 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fmt
1f6bc02 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
add back ingest sst with compat_old_proxy, to fix some bugs
9adabd8 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fix
b71dcc9 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
add comment
8b72794 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
f
e529489 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo CalvinNeo requested a review from breezewish August 15, 2022 09:05
CalvinNeo and others added 7 commits August 15, 2022 17:35
@CalvinNeo
Merge branch 'migrate-post-exec' of github.com:CalvinNeo/tidb-engine-…
b2958e8 
…ext into migrate-post-exec
@CalvinNeo
f
3bae7d3 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
f
c6bcbca 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo CalvinNeo merged commit 0703d9f into pingcap:raftstore-proxy-6.2 Aug 23, 2022
@CalvinNeo CalvinNeo mentioned this pull request Aug 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CalvinNeo @breezewish