Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add timezone information #974

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

shhdgit
Copy link
Member

@shhdgit shhdgit commented Aug 5, 2021

Related: #973 . Add timezone information.

covered cases:

  • table field
  • tooltip

not covered:

  • form value (unnecessary)
  • chart value (should be shorter and clearer)

image

image

image

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 5, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shhdgit
Copy link
Member Author

shhdgit commented Aug 5, 2021

/cc @baurine @breeswish
PTAL, thanks~

@breezewish
Copy link
Member

Good job!

@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e030d66

@ti-chi-bot ti-chi-bot merged commit d4dd446 into pingcap:master Aug 6, 2021
shhdgit added a commit to shhdgit/tidb-dashboard that referenced this pull request Sep 2, 2021
shhdgit added a commit that referenced this pull request Sep 2, 2021
* feat(ui): add timezone information (#974)

* Fix endpoint scheme detection for TLS origination to PD (#977)

* build(deps): bump path-parse from 1.0.6 to 1.0.7 in /ui (#978)

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump path-parse from 1.0.6 to 1.0.7 in /ui/tests (#981)

* Bump golangci to get the latest lints & fix lints (#984)

* Ci cherry pick version (#989)

* chore: add distro translation (#995)

* chore: add distro translation

* fix: lowercase

* update: release version

Co-authored-by: LINKIWI <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants