Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: label of y-axis is overflow #924

Merged
merged 2 commits into from
May 13, 2021
Merged

fix: label of y-axis is overflow #924

merged 2 commits into from
May 13, 2021

Conversation

unbyte
Copy link
Contributor

@unbyte unbyte commented May 12, 2021

fix #890

image

breezewish
breezewish reviewed May 12, 2021
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Interesting! Why will it work by even reducing the space?

@unbyte
Copy link
Contributor Author

unbyte commented May 12, 2021

with grid.containLabel=true, echarts will take the width of the label into account when rendering

@breezewish
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6e033ac

@ti-chi-bot ti-chi-bot merged commit 2f4cc86 into pingcap:master May 13, 2021
shhdgit pushed a commit to shhdgit/tidb-dashboard that referenced this pull request Jun 15, 2021
@unbyte @shhdgit
fix: label of y-axis is overflow (pingcap#924)
a32f4ed
breezewish pushed a commit that referenced this pull request Jun 15, 2021
@shhdgit
Release v2021.06.15.1 (#938)
6bbc7e6 
* fix: label of y-axis is overflow (#924)
* update(deps): upgrade gorm to v2 (#916)
* debug_api: Add more endpoints (#927)
* fix(ui): localstorage compatibility issue (#930)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish left review comments

Assignees
No one assigned
Labels
status/can-merge status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QPS Data Over 100K got trimmed
3 participants
@unbyte @breezewish @ti-chi-bot