Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statement,slowquery: add request unit part in list #1639

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Jan 9, 2024

Statement:

image

Image

Slow Qurey

image
Image

@ti-chi-bot ti-chi-bot bot requested a review from Renkai January 9, 2024 10:55
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for tidb-dashboard canceled.

Name Link
🔨 Latest commit bc241e4
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/659e6daeb463c60009a64947

@ti-chi-bot ti-chi-bot bot added the size/L label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a275ed) 24.03% compared to head (bc241e4) 24.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1639      +/-   ##
==========================================
+ Coverage   24.03%   24.14%   +0.11%     
==========================================
  Files         173      173              
  Lines       15679    15689      +10     
==========================================
+ Hits         3768     3788      +20     
+ Misses      11628    11618      -10     
  Partials      283      283              
Flag Coverage Δ
backend_integration 9.18% <100.00%> (+0.16%) ⬆️
backend_ut 26.28% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a275ed...bc241e4. Read the comment docs.

@nolouch nolouch force-pushed the support-ru branch 3 times, most recently from 8058223 to d226db2 Compare January 9, 2024 15:39
Signed-off-by: nolouch <[email protected]>
Copy link
Collaborator

@baurine baurine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest lgtm

@nolouch
Copy link
Member Author

nolouch commented Jan 10, 2024

ptal @mornyx @baurine

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Jan 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-11 01:12:42.623180851 +0000 UTC m=+492152.207434539: ☑️ agreed by baurine.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit d877c1a into pingcap:master Jan 11, 2024
16 checks passed
@baurine
Copy link
Collaborator

baurine commented Jan 11, 2024

/cherry-pick release-7.6

@nolouch nolouch deleted the support-ru branch January 11, 2024 03:36
nolouch added a commit to nolouch/tidb-dashboard that referenced this pull request Jan 11, 2024
@@ -25,9 +27,15 @@ func genSelectStmt(tableColumns []string, reqJSONColumns []string) (string, erro

// We have both TiDB 4.x and TiDB 5.x columns listed in the model. Filter out columns that do not exist in current version TiDB schema.
fields = lo.Filter(fields, func(f Field, _ int) bool {
hasProjection := f.Projection != ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late reply.. Why is hasProjection no longer needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use related to replace it, the same as in the statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants