-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statement,slowquery: add request unit part in list #1639
Conversation
✅ Deploy Preview for tidb-dashboard canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1639 +/- ##
==========================================
+ Coverage 24.03% 24.14% +0.11%
==========================================
Files 173 173
Lines 15679 15689 +10
==========================================
+ Hits 3768 3788 +20
+ Misses 11628 11618 -10
Partials 283 283
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Signed-off-by: nolouch <[email protected]>
8058223
to
d226db2
Compare
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the rest lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baurine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/cherry-pick release-7.6 |
@@ -25,9 +27,15 @@ func genSelectStmt(tableColumns []string, reqJSONColumns []string) (string, erro | |||
|
|||
// We have both TiDB 4.x and TiDB 5.x columns listed in the model. Filter out columns that do not exist in current version TiDB schema. | |||
fields = lo.Filter(fields, func(f Field, _ int) bool { | |||
hasProjection := f.Projection != "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my late reply.. Why is hasProjection
no longer needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use related
to replace it, the same as in the statement.
Statement:
Slow Qurey