Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove un-used code #1638

Merged
merged 1 commit into from
Jan 8, 2024
Merged

chore: remove un-used code #1638

merged 1 commit into from
Jan 8, 2024

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Jan 8, 2024

Remove the un-used tidb-dashboard-for-dbaas package

@ti-chi-bot ti-chi-bot bot requested a review from Renkai January 8, 2024 09:47
Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit 2327004
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/659bc49330f9340008f49d2d
😎 Deploy Preview https://deploy-preview-1638--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@baurine baurine requested review from shhdgit and removed request for Renkai January 8, 2024 09:47
@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3ac98a) 24.04% compared to head (2327004) 24.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1638      +/-   ##
==========================================
- Coverage   24.04%   24.03%   -0.02%     
==========================================
  Files         173      173              
  Lines       15679    15679              
==========================================
- Hits         3770     3768       -2     
- Misses      11626    11628       +2     
  Partials      283      283              
Flag Coverage Δ
backend_integration 9.06% <ø> (+0.03%) ⬆️
backend_ut 26.26% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ac98a...2327004. Read the comment docs.

Copy link
Member

@shhdgit shhdgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shhdgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-08 10:21:15.662848746 +0000 UTC m=+265865.247102418: ☑️ agreed by shhdgit.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 8, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2a275ed into master Jan 8, 2024
15 of 16 checks passed
@ti-chi-bot ti-chi-bot bot deleted the chore/cleanup branch January 8, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants