Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slow-query): support slow query search by digest #1636

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Jan 8, 2024

Changes

  1. Support search slow query by digest filter
  2. Expand the TopSQL select instances component width
  3. Handle the compatibility issues when querying TiCDC and TiProxy components under TiDB 7.6.0

Preview

image

image

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit b139075
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/659ba7e95baa3c000804dfc9
😎 Deploy Preview https://deploy-preview-1636--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ti-chi-bot ti-chi-bot bot requested a review from Renkai January 8, 2024 07:44
@ti-chi-bot ti-chi-bot bot added the size/M label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (473bf80) 9.02% compared to head (b139075) 24.04%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1636       +/-   ##
===========================================
+ Coverage    9.02%   24.04%   +15.02%     
===========================================
  Files         127      173       +46     
  Lines       13365    15679     +2314     
===========================================
+ Hits         1206     3770     +2564     
+ Misses      12028    11626      -402     
- Partials      131      283      +152     
Flag Coverage Δ
backend_integration 9.02% <ø> (ø)
backend_ut 26.28% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 473bf80...b139075. Read the comment docs.

Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2024

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mornyx
Once this PR has been reviewed and has the lgtm label, please ask for approval from baurine. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baurine baurine merged commit 04cf26b into master Jan 8, 2024
14 of 16 checks passed
@baurine baurine deleted the feat/slow-query-search-by-digest branch January 8, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants