Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add backend supports for tiproxy & ticdc #1628

Merged
merged 8 commits into from
Dec 29, 2023
Merged

*: add backend supports for tiproxy & ticdc #1628

merged 8 commits into from
Dec 29, 2023

Conversation

mornyx
Copy link
Collaborator

@mornyx mornyx commented Dec 24, 2023 •
edited by baurine
Loading

Add backend supports for TiProxy:

  • Cluster Info
  • Manual Profiling
  • Debug Data (no endpoints exposed yet)

Also complete above backend supports for TiCDC.

FE PR: #1629

@ti-chi-bot ti-chi-bot bot requested a review from Renkai December 24, 2023 11:35
@netlify Netlify
Copy link

netlify bot commented Dec 24, 2023 •
edited
Loading

✅ Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit d24741c
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/658ea2e3258e1e000881e38b
😎 Deploy Preview https://deploy-preview-1628--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mornyx mornyx marked this pull request as draft December 24, 2023 11:36
@codecov Codecov
Copy link

codecov bot commented Dec 24, 2023 •
edited
Loading

Codecov Report

Attention: 242 lines in your changes are missing coverage. Please review.

Comparison is base (270f21d) 24.39% compared to head (d24741c) 24.04%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
- Coverage   24.39%   24.04%   -0.36%     
==========================================
  Files         170      173       +3     
  Lines       15436    15679     +243     
==========================================
+ Hits         3766     3770       +4     
- Misses      11387    11626     +239     
  Partials      283      283
Flag Coverage Δ
backend_integration 9.06% <1.70%> (-0.10%) ⬇️
backend_ut 26.28% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 270f21d...d24741c. Read the comment docs.

mornyx and others added 5 commits December 26, 2023 16:09
@mornyx
fix port type of tiproxy in etcd
1121ab9 
Signed-off-by: mornyx <[email protected]>
@mornyx
add tiproxy to hostinfo
d80bc57 
Signed-off-by: mornyx <[email protected]>
@mornyx
use uint port for topology/tiproxy response
a236e4f 
Signed-off-by: mornyx <[email protected]>
@mornyx
Merge branch 'master' into mornyx/tiproxy
dd2153b
@baurine
feat: support TiProxy & TiCDC components in FE side (#1629)
ebbfce1 
* chore: add generated spec files

* feat(tiproxy): support overview/clusterinfo/searchlogs (wip)

* feat(tiproxy): support search logs

* feat: support manual profiling for tiproxy and ticdc

* feat: add metrics for tiproxy

* revert /api prefix

* update promql for tiproxy
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 29, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 29, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Dec 29, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-29 10:34:04.048534354 +0000 UTC m=+1821135.085761281: ☑️ agreed by baurine.
  • 2023-12-29 10:43:48.474474675 +0000 UTC m=+1821719.511701587: ✖️🔁 reset by baurine.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2023

New changes are detected. LGTM label has been removed.

@mornyx mornyx marked this pull request as ready for review December 29, 2023 10:50
@mornyx mornyx added this pull request to the merge queue Dec 29, 2023
@baurine baurine removed this pull request from the merge queue due to a manual request Dec 29, 2023
@baurine baurine added this pull request to the merge queue Dec 29, 2023
@baurine baurine removed this pull request from the merge queue due to a manual request Dec 29, 2023
@baurine baurine merged commit c736225 into master Dec 29, 2023
12 of 16 checks passed
@baurine baurine deleted the mornyx/tiproxy branch December 29, 2023 10:56
@mornyx mornyx mentioned this pull request Jan 10, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baurine baurine baurine approved these changes

@Renkai Renkai Awaiting requested review from Renkai

Assignees
No one assigned
Labels
approved area/frontend size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mornyx @baurine