Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix goleak check #1619

Merged
merged 1 commit into from
Nov 27, 2023
Merged

chore: fix goleak check #1619

merged 1 commit into from
Nov 27, 2023

Conversation

mornyx
Copy link
Collaborator

@mornyx mornyx commented Nov 27, 2023

Ignore github.com/ReneKroon/ttlcache/v2.(*Cache).startExpirationProcessing

@ti-chi-bot ti-chi-bot bot requested a review from Renkai November 27, 2023 03:04
Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for tidb-dashboard canceled.

Name Link
🔨 Latest commit fe8f8fc
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/65640744b1b566000836e87d

@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #1619 (fe8f8fc) into master (871aa0a) will increase coverage by 15.37%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1619       +/-   ##
===========================================
+ Coverage    9.23%   24.60%   +15.37%     
===========================================
  Files         123      169       +46     
  Lines       13007    15299     +2292     
===========================================
+ Hits         1201     3765     +2564     
+ Misses      11675    11251      -424     
- Partials      131      283      +152     
Flag Coverage Δ
backend_integration 9.23% <ø> (ø)
backend_ut 26.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 871aa0a...fe8f8fc. Read the comment docs.

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 27, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 27, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-27 03:10:20.868698522 +0000 UTC m=+805849.533924702: ☑️ agreed by baurine.

@mornyx mornyx added this pull request to the merge queue Nov 27, 2023
@mornyx mornyx removed this pull request from the merge queue due to a manual request Nov 27, 2023
@mornyx mornyx merged commit 6d12216 into master Nov 27, 2023
13 checks passed
@mornyx mornyx deleted the mornyx/fix-ut branch November 27, 2023 03:18
mornyx added a commit that referenced this pull request Nov 27, 2023
@mornyx mornyx mentioned this pull request Nov 27, 2023
baurine added a commit that referenced this pull request Nov 27, 2023
* *: update gin to v1.9.1 for security reason (#1616)

* chore: fix goleak check (#1619)

Signed-off-by: mornyx <[email protected]>

* fix: update axios to fix security issue (#1617)

* Release v20231127.1

Signed-off-by: mornyx <[email protected]>

---------

Signed-off-by: mornyx <[email protected]>
Co-authored-by: Sparkle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants