Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prometheus.registry #1183

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Release note

  • No release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 29, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@lichunzhu: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added size/XS and removed size/L labels Jul 29, 2022
sleepymole
sleepymole approved these changes Jul 29, 2022
if gatherer, ok := registry.(prometheus.Gatherer); ok {
prometheus.DefaultGatherer = gatherer
}
prometheus.DefaultGatherer = registry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: When using the global registry, it can be simplified to prometheus.MustRegister.

@lichunzhu lichunzhu merged commit 39d35ea into pingcap:release-3.0-20220729 Jul 29, 2022
lichunzhu added a commit to lichunzhu/tidb-binlog that referenced this pull request Aug 1, 2022
* reparo support pprof

* fix
lichunzhu added a commit that referenced this pull request Aug 1, 2022
* reparo support pprof (#1182)

* fix prometheus.registry (#1183)

* reparo support pprof

* fix

* update go.mod

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants