fix: remove warning for "REORGANIZE PARTITION" (#605) #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that in commit fdfeac in pingcap/tidb the errror was already handled. Need to do nothing. Signed-off-by: Wang Ruichao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #924 +/- ##
==========================================
- Coverage 78.43% 78.42% -0.01%
==========================================
Files 40 40
Lines 14897 14775 -122
==========================================
- Hits 11685 11588 -97
+ Misses 2521 2500 -21
+ Partials 691 687 -4 |
…tion Signed-off-by: Wang Ruichao <[email protected]>
djshow832
reviewed
Jul 18, 2020
|
@djshow832 The error has been added in TiDB. |
ti-srebot
approved these changes
Jul 18, 2020
kennytm
approved these changes
Jul 18, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
…#924) Note that in commit fdfeac in pingcap/tidb the errror was already handled. Need to do nothing. Signed-off-by: Wang Ruichao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that in commit fdfeac in pingcap/tidb the errror was already handled.
Need to do nothing.
Signed-off-by: Wang Ruichao [email protected]
What problem does this PR solve?
Close #605 (cc #598)
What is changed and how it works?
Update judgement in parser.y.
Note that in my opinion "REORGANIZE PARTITION" is a part of partition options, I moved it to "AlterTablePartitionOpt". If not, I'll rollback.
Check List
Tests