Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] *: support parsing all PARTITION BY syntax (#345) #395

Merged

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Jul 22, 2019

What problem does this PR solve?

Cherry-picks #345 to release-3.0.

See also pingcap/tidb#11373.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects

Related changes

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-3.0@c3bdffe). Click here to learn what that means.
The diff coverage is 4.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-3.0     #395   +/-   ##
==============================================
  Coverage               ?   51.02%           
==============================================
  Files                  ?       31           
  Lines                  ?     6840           
  Branches               ?        0           
==============================================
  Hits                   ?     3490           
  Misses                 ?     3001           
  Partials               ?      349
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø)
misc.go 96.42% <ø> (ø)
model/model.go 37.64% <0%> (ø)
terror/terror.go 71.77% <0%> (ø)
ast/ddl.go 44.47% <4.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3bdffe...bd2bba5. Read the comment docs.

@kennytm
Copy link
Contributor Author

kennytm commented Jul 24, 2019

PTAL @crazycs520

@kennytm
Copy link
Contributor Author

kennytm commented Aug 1, 2019

Ping @crazycs520

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 LGT1 label Aug 5, 2019
@tiancaiamao
Copy link
Collaborator

LGTM

@tiancaiamao tiancaiamao added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Aug 5, 2019
@kennytm kennytm merged commit d4d0733 into pingcap:release-3.0 Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants