Parser: Support SQL_BIG_RESULT, SQL_SMALL_RESULT, SQL_BUFFER_RESULT #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kennytm
reviewed
Apr 26, 2019
|
Thank you for working on this! It is good to have this for MySQL compatibility. |
|
@b41sh Can you fix the formatting of |
|
ok |
|
@morgo PTAL |
|
LGTM, but I am a product manager :-) PTAL @lysu @tiancaiamao |
|
PTAL @crazycs520 |
|
LGTM |
This comment has been minimized.
This comment has been minimized.
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
=========================================
- Coverage 53.35% 53.3% -0.05%
=========================================
Files 31 31
Lines 6524 6530 +6
=========================================
Hits 3481 3481
- Misses 2704 2707 +3
- Partials 339 342 +3
Continue to review full report at Codecov.
|
kennytm
approved these changes
May 29, 2019
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
…ingcap#304) * Support SQL_BIG_RESULT, SQL_SMALL_RESULT, SQL_BUFFER_RESULT * update test case * code formatting * word wrap
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
…ingcap#304) * Support SQL_BIG_RESULT, SQL_SMALL_RESULT, SQL_BUFFER_RESULT * update test case * code formatting * word wrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support
SQL_BIG_RESULT,SQL_SMALL_RESULT,SQL_BUFFER_RESULTSyntax for TiDB Parser. Fixed #141What is changed and how it works?
Add related syntax in parser.y
Add SQL_BIG_RESULT, SQL_SMALL_RESULT, SQL_BUFFER_RESULT in SelectStmtOpts
Update SelectStmt.Restore
Check List
Tests