wip:*: Support sytax of reset placement options
#1353
Conversation
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
how can we split “default” (policy name) with default (keyword)? or we just support SET DEFAULT syntax? |
sylzd
changed the title
reset db placement optionsclear db placement options
sylzd
changed the title
clear db placement optionsreset db placement options
| ctx.WriteKeyWord("DEFAULT") | ||
| } else { | ||
| ctx.WriteName(n.StrValue) | ||
| } |
There was a problem hiding this comment.
if you want 'DEFAULT' and DEFAULT to be distinguishable you should create a separate PlacementOptionType. playing tricks in Restore() won't do much.
There was a problem hiding this comment.
We also want to make `DEFAULT`(identifier) differs from DEFAULT (keyword) 🤣, does it work?
There was a problem hiding this comment.
yes. "DEFAULT" in parser.y always refer to the keyword. since DEFAULT is a reserved keyword it shouldn't collide with Identifier.
There was a problem hiding this comment.
Sounds great to me, I will try it.😆
sylzd
changed the title
reset db placement optionsreset db placement options
sylzd
changed the title
reset db placement optionsreset placement options
|
merged to pingcap/tidb#28463 by pingcap/tidb#28257 |
What problem does this PR solve?
Issue Number: pingcap/tidb#18203
related to pingcap/tidb#18203
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes