-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser,ast: Support for authentication plugins #1236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/LGTM |
Merged
tiancaiamao
reviewed
Jun 3, 2021
rest LGTM |
@morgo @tiancaiamao PTAL |
morgo
approved these changes
Jun 3, 2021
@tiancaiamao could you have another look? |
/LGTM |
ti-srebot
approved these changes
Jun 7, 2021
tiancaiamao
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Required changes to support authentication plugins in
CREATE USER
statements.What is changed and how it works?
ast.AuthOption.AuthPlugin
HashString
. This improves MySQL compatibility and makes it easier to use withcaching_sha2_password
which can contain non-ASCII/non-printable characters.Note that the
IDENTIFIED BY PASSWORD <HashString>
is still excepted, but when restoring this this gets rewritten asIDENTIFIED BY 'mysql_native_password' AS <HashString>
. The former is no longer supported by MySQL 8.0.Check List
Tests
Code changes
Side effects
Note that this is based on top of:
This is needed for pingcap/tidb#24991 to be able to support
CREATE USER
statements that create users withcaching_sha2_password
support.