Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: change privilege type to uint64 and support REPLICATION CLIENT, etc #1121

Merged
merged 6 commits into from
Dec 22, 2020
Merged

*: change privilege type to uint64 and support REPLICATION CLIENT, etc #1121

merged 6 commits into from
Dec 22, 2020

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Dec 7, 2020 •
edited
Loading

What problem does this PR solve?

close #1119

What is changed and how it works?

  • change PrivilegeType from uint32 to uint64
  • add constant and restore string for USAGE, REPLICATION CLIENT, REPLICATION SLAVE

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@kennytm kennytm added the DNM label Dec 7, 2020
@lance6716 lance6716 removed the DNM label Dec 8, 2020
@lance6716 lance6716 changed the title [DNM] mysql: change privilege type to uint64 mysql: change privilege type to uint64 and support REPLICATION CLIENT, etc Dec 8, 2020
@lance6716 lance6716 requested a review from zier-one December 8, 2020 12:15
@lance6716 lance6716 changed the title mysql: change privilege type to uint64 and support REPLICATION CLIENT, etc *: change privilege type to uint64 and support REPLICATION CLIENT, etc Dec 8, 2020
@lance6716
Copy link
Contributor Author

PTAL @leoppro

@lance6716
Copy link
Contributor Author

PTAL @leoppro @wjhuang2016

wjhuang2016
wjhuang2016 reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Dec 17, 2020
@lance6716
Copy link
Contributor Author

integration test failed, TiDB throws many error 🤔

@lance6716 lance6716 mentioned this pull request Dec 17, 2020
Merged
@lance6716
Copy link
Contributor Author

need pingcap/tidb#21856

@lance6716
Copy link
Contributor Author

ping @leoppro

xhebox
xhebox approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Dec 22, 2020
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Dec 22, 2020
@xhebox
Copy link
Contributor

xhebox commented Dec 22, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@lance6716 lance6716 merged commit 12abf04 into pingcap:master Dec 22, 2020
@lance6716 lance6716 deleted the 64-priv branch December 22, 2020 02:26
@ti-srebot ti-srebot mentioned this pull request Dec 30, 2020
Merged
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@lance6716
*: change privilege type to uint64 and support REPLICATION CLIENT, etc (
bae488b 
pingcap#1121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@xhebox xhebox xhebox approved these changes

@zier-one zier-one Awaiting requested review from zier-one

Assignees
No one assigned
Labels
status/can-merge status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parser gives privileges a exclusive bit or shared bit?
5 participants
@lance6716 @xhebox @ti-srebot @wjhuang2016 @kennytm