Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast: add explain format=json #1055

Merged
merged 4 commits into from Oct 22, 2020
Merged

ast: add explain format=json #1055

merged 4 commits into from Oct 22, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 14, 2020

What problem does this PR solve?

Parser component of pingcap/tidb#20378

What is changed and how it works?

The ast is modified to make the syntax EXPLAIN FORMAT=JSON SelectStmt valid. This is already valid syntax in MySQL, which supports the formats tree/traditional/json.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Minimal

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2020

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link
Author

ghost commented Oct 14, 2020

/run-all-tests

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Oct 20, 2020
@kennytm kennytm merged commit 9cbe1c7 into pingcap:master Oct 22, 2020
@ghost ghost deleted the add-explain-format-json branch October 22, 2020 17:17
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants