Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import_sst: added errorpb.Error variant for the Error #879

Merged
merged 1 commit into from
Mar 10, 2022
Merged

import_sst: added errorpb.Error variant for the Error #879

merged 1 commit into from
Mar 10, 2022

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Mar 9, 2022

We need the information of store for better retrying in the log restore (for the Apply RPC).

@YuJuncen YuJuncen mentioned this pull request Mar 9, 2022
Merged
3 tasks
@YuJuncen YuJuncen requested review from kennytm, joccau and 3pointer March 9, 2022 11:43
joccau
joccau approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3pointer 3pointer merged commit 4f14da8 into pingcap:br-stream Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joccau joccau joccau approved these changes

@3pointer 3pointer 3pointer approved these changes

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuJuncen @3pointer @joccau