Add ConfChange::AddLearnerNode command. #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
PTAL @overvenus @BusyJay |
|
LGTM |
|
@BusyJay PTAL thanks. |
BusyJay
reviewed
Nov 16, 2017
proto/pdpb.proto
Outdated
| @@ -233,6 +233,7 @@ message RegionHeartbeatRequest { | |||
| enum ConfChangeType { | |||
| AddNode = 0; | |||
| RemoveNode = 1; | |||
| AddLearnerNode = 2; | |||
There was a problem hiding this comment.
I thought pd should also support add learner node command.
|
Please add pr description to show where the changes come from. |
|
@BusyJay PTAL thanks. |
overvenus
reviewed
Nov 17, 2017
proto/eraftpb.proto
Outdated
| @@ -72,11 +72,13 @@ message HardState { | |||
|
|
|||
| message ConfState { | |||
| repeated uint64 nodes = 1; | |||
| repeated uint64 learner_nodes = 2; | |||
There was a problem hiding this comment.
Why not learners[0]?
[0] https://github.com/coreos/etcd/pull/8751/files#diff-ed53c23ad570cdd6dce39cbd1b751cacR80
BusyJay
reviewed
Nov 17, 2017
proto/metapb.proto
Outdated
| @@ -51,6 +51,7 @@ message Region { | |||
| optional bytes end_key = 3; | |||
| optional RegionEpoch region_epoch = 4; | |||
| repeated Peer peers = 5; | |||
| repeated Peer learners = 6; | |||
|
@BusyJay @overvenus PTAL thanks. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for support raft learner. See etcd-io/etcd#8751