remove duplicate error code check and add some public method

terror_error.go

@@ -19,6 +19,9 @@ import (
 	"runtime"
 	"strconv"
 	"strings"
+
+	"github.com/pingcap/log"
+	"go.uber.org/zap"
 )
 
 // Error is the 'prototype' of a type of errors.
@@ -128,10 +131,10 @@ func (e *Error) Error() string {
 	if len(describe) == 0 {
 		describe = ErrCodeText(strconv.Itoa(int(e.code)))
 	}
-	return fmt.Sprintf("[%s] %s", e.RFCCode(), e.getMsg())
+	return fmt.Sprintf("[%s] %s", e.RFCCode(), e.GetMsg())
 }
 
-func (e *Error) getMsg() string {
+func (e *Error) GetMsg() string {
 	if len(e.args) > 0 {
 		return fmt.Sprintf(e.message, e.args...)
 	}
@@ -251,7 +254,7 @@ type jsonError struct {
 // This function is reserved for compatibility.
 func (e *Error) MarshalJSON() ([]byte, error) {
 	return json.Marshal(&jsonError{
-		Error:       e.getMsg(),
+		Error:       e.GetMsg(),
 		Description: e.Description,
 		Workaround:  e.Workaround,
 		RFCCode:     e.RFCCode(),
@@ -291,3 +294,28 @@ func (e *Error) UnmarshalJSON(data []byte) error {
 	}
 	return nil
 }
+
+// MustNil cleans up and fatals if err is not nil.
+func MustNil(err error, closeFuns ...func()) {
+	if err != nil {
+		for _, f := range closeFuns {
+			f()
+		}
+		log.Fatal("unexpected error", zap.Error(err))
+	}
+}
+
+// Call executes a function and checks the returned err.
+func Call(fn func() error) {
+	err := fn()
+	if err != nil {
+		log.Error("function call errored", zap.Error(err))
+	}
+}
+
+// Log logs the error if it is not nil.
+func Log(err error) {
+	if err != nil {
+		log.Error("encountered error", zap.Error(WithStack(err)))
+	}
+}

terror_registry.go

@@ -27,6 +27,25 @@ type Registry struct {
 // Same error code can be used in different error classes.
 type ErrCode int
 
+const (
+	// Executor error codes.
+
+	// CodeUnknown is for errors of unknown reason.
+	CodeUnknown ErrCode = -1
+	// CodeExecResultIsEmpty indicates execution result is empty.
+	CodeExecResultIsEmpty ErrCode = 3
+
+	// Expression error codes.
+
+	// CodeMissConnectionID indicates connection id is missing.
+	CodeMissConnectionID ErrCode = 1
+
+	// Special error codes.
+
+	// CodeResultUndetermined indicates the sql execution result is undetermined.
+	CodeResultUndetermined ErrCode = 2
+)
+
 // ErrCodeText is a textual error code that represents a specific error type in a error class.
 type ErrCodeText string
 
@@ -134,9 +153,6 @@ func (ec *ErrClass) DefineError() *Builder {
 // RegisterError try to register an error to a class.
 // return true if success.
 func (ec *ErrClass) RegisterError(err *Error) bool {
-	if _, ok := ec.errors[err.ID()]; ok {
-		return false
-	}
 	err.class = ec
 	ec.errors[err.ID()] = err
 	return true