Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-variables: add tidb_enable_paging #7352

Merged
merged 9 commits into from
Jan 11, 2022
Merged

system-variables: add tidb_enable_paging #7352

merged 9 commits into from
Jan 11, 2022

Conversation

you06
Copy link
Contributor

@you06 you06 commented Dec 31, 2021

Signed-off-by: you06 [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a new environment variable which controls coprocessor paging for IndexLookUp executor, ref pingcap/tidb#30578.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 31, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • en-jin19
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn December 31, 2021 06:13
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 31, 2021
@you06 you06 mentioned this pull request Dec 31, 2021
Merged
15 tasks
@TomShawn TomShawn added area/transaction Indicates that the Issue or PR belongs to the area of transaction. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.4 This PR/issue applies to TiDB v5.4. and removed missing-translation-status This PR does not have translation status info. labels Dec 31, 2021
@ran-huang ran-huang added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jan 4, 2022
ran-huang
ran-huang reviewed Jan 4, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
you06
you06 commented Jan 4, 2022
View reviewed changes
system-variables.md Outdated

- Scope: SESSION | GLOBAL
- Default value: `OFF`
- This variable controls whether to use paging to send coprocessor requests in `IndexLookUp` operator.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"whether to use the method of paging to send coprocessor"
Is this better?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

system-variables.md Outdated Show resolved Hide resolved
ran-huang and others added 2 commits January 5, 2022 09:00
@you06
Copy link
Contributor Author

you06 commented Jan 5, 2022

LGTM

@ran-huang ran-huang requested review from en-jin19 and removed request for TomShawn January 5, 2022 05:43
en-jin19
en-jin19 reviewed Jan 5, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@qiancai qiancai assigned ran-huang and unassigned ran-huang Jan 7, 2022
ran-huang
ran-huang reviewed Jan 10, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@ran-huang: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

en-jin19
en-jin19 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@en-jin19 en-jin19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 11, 2022
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1d11d59

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 11, 2022
@ti-chi-bot ti-chi-bot merged commit 2963108 into pingcap:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@en-jin19 en-jin19 en-jin19 approved these changes

@ran-huang ran-huang ran-huang approved these changes

@youjiali1995 youjiali1995 youjiali1995 approved these changes

Assignees
No one assigned
Labels
area/transaction Indicates that the Issue or PR belongs to the area of transaction. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@you06 @ti-chi-bot @ran-huang @youjiali1995 @en-jin19 @TomShawn