Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pitr: update the description of performance capabilities #18899

Merged
merged 4 commits into from
Sep 24, 2024
Merged

pitr: update the description of performance capabilities #18899

merged 4 commits into from
Sep 24, 2024

Conversation

yiduoyunQ
Copy link
Contributor

@yiduoyunQ yiduoyunQ commented Sep 12, 2024 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

add explicit command so customer can know what's command it executed

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@yiduoyunQ
Copy link
Contributor Author

docs-cn pingcap/docs-cn#18622

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 12, 2024
@yiduoyunQ yiduoyunQ mentioned this pull request Sep 12, 2024
Merged
16 tasks
@Oreoxmt Oreoxmt self-assigned this Sep 24, 2024
@Oreoxmt Oreoxmt self-requested a review September 24, 2024 03:46
@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. labels Sep 24, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 24, 2024
@yiduoyunQ
Update br-pitr-guide.md
009080d 
使用文档中前面已有描述
Oreoxmt
Oreoxmt reviewed Sep 24, 2024
View reviewed changes
br/br-pitr-guide.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 24, 2024
@Oreoxmt Oreoxmt changed the title refine-pitr-doc pitr: update the description of performance capabilities Sep 24, 2024
qiancai
qiancai approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

br/br-pitr-guide.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 24, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-24 07:25:05.348653741 +0000 UTC m=+1550775.089077678: ☑️ agreed by Oreoxmt.
  • 2024-09-24 07:36:29.996585988 +0000 UTC m=+1551459.737009936: ☑️ agreed by qiancai.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Sep 24, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 24, 2024
@ti-chi-bot ti-chi-bot bot merged commit 797c277 into pingcap:master Sep 24, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18997.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18998.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #18999.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #19000.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #19001.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #19002.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2024
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Sep 24, 2024
@ti-chi-bot
pitr: update the description of performance capabilities (#18899) (#1…
35be391 
…8997)
ti-chi-bot bot pushed a commit that referenced this pull request Sep 24, 2024
@ti-chi-bot
pitr: update the description of performance capabilities (#18899) (#1…
e412f5a 
…9000)
ti-chi-bot bot pushed a commit that referenced this pull request Sep 24, 2024
@ti-chi-bot
pitr: update the description of performance capabilities (#18899) (#1…
1a0a415 
…8999)
ti-chi-bot bot pushed a commit that referenced this pull request Sep 24, 2024
@ti-chi-bot
pitr: update the description of performance capabilities (#18899) (#1…
765aa04 
…9001)
ti-chi-bot bot pushed a commit that referenced this pull request Sep 24, 2024
@ti-chi-bot
pitr: update the description of performance capabilities (#18899) (#1…
e4e5e25 
…9002)
ti-chi-bot bot pushed a commit that referenced this pull request Sep 24, 2024
@ti-chi-bot
pitr: update the description of performance capabilities (#18899) (#1…
aa1f57d 
…8998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yiduoyunQ @Oreoxmt @ti-chi-bot @qiancai