Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: enable-relay is undeprecated since v5.4.0 #18781

Merged
merged 2 commits into from
Jan 21, 2025
Merged

dm: enable-relay is undeprecated since v5.4.0 #18781

merged 2 commits into from
Jan 21, 2025

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Sep 3, 2024

What is changed, added or deleted? (Required)

Remove the note about enable-relay being deprecated, as it has been resupported since v5.4.0.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@kennytm kennytm added the area/dm label Sep 3, 2024
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2024
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jan 21, 2025
@hfxsd hfxsd self-assigned this Jan 21, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 21, 2025
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. and removed translation/doing This PR's assignee is translating this PR. labels Jan 21, 2025
@hfxsd hfxsd mentioned this pull request Jan 21, 2025
Merged
16 tasks
@hfxsd hfxsd requested review from CbcWestwolf and GMHDBJD and removed request for CbcWestwolf January 21, 2025 12:36
GMHDBJD
GMHDBJD approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 21, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-21 12:33:08.41680879 +0000 UTC m=+184115.747728188: ☑️ agreed by hfxsd.
  • 2025-01-21 13:44:45.239125503 +0000 UTC m=+188412.570044919: ☑️ agreed by GMHDBJD.

@purelind
Copy link

/cherry-pick release-8.3

@purelind
Copy link

/cherry-pick release-7.5

@purelind
Copy link

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@purelind: new pull request created to branch release-8.4: #20089.

In response to this:

/cherry-pick release-8.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2025
Merged
15 tasks
@ti-chi-bot
Copy link
Member

@purelind: new pull request created to branch release-8.3: #20090.

In response to this:

/cherry-pick release-8.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2025
Merged
15 tasks
@ti-chi-bot
Copy link
Member

@purelind: new pull request created to branch release-7.5: #20091.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2025
Merged
15 tasks
@ti-chi-bot
Copy link
Member

@purelind: new pull request created to branch release-7.1: #20092.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2025
Merged
15 tasks
@purelind
Copy link

/cherry-pick release-6.5

@purelind
Copy link

/cherry-pick release-6.1

@purelind
Copy link

/cherry-pick release-5.4

@ti-chi-bot
Copy link
Member

@purelind: new pull request created to branch release-6.5: #20093.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2025
Merged
15 tasks
@ti-chi-bot
Copy link
Member

@purelind: new pull request created to branch release-6.1: #20094.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2025
Merged
15 tasks
@ti-chi-bot
Copy link
Member

@purelind: new pull request created to branch release-5.4: #20095.

In response to this:

/cherry-pick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jan 22, 2025
@kennytm @ti-chi-bot
This is an automated cherry-pick of pingcap#18781
6f2ceb7 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2025
Merged
15 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
dm: enable-relay is undeprecated since v5.4.0 (#18781) (#20089)
f49affb
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
dm: enable-relay is undeprecated since v5.4.0 (#18781) (#20088)
bc18cfe
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
dm: enable-relay is undeprecated since v5.4.0 (#18781) (#20091)
da7e980
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
dm: enable-relay is undeprecated since v5.4.0 (#18781) (#20092)
591ea98
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
dm: enable-relay is undeprecated since v5.4.0 (#18781) (#20090)
6c4aaa1
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
dm: enable-relay is undeprecated since v5.4.0 (#18781) (#20094)
390a2c2
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
dm: enable-relay is undeprecated since v5.4.0 (#18781) (#20093)
346f6f2
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
dm: enable-relay is undeprecated since v5.4.0 (#18781) (#20087)
dafe3c9
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
dm: enable-relay is undeprecated since v5.4.0 (#18781) (#20095)
c22088a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees

@hfxsd hfxsd

Labels
approved area/dm lgtm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kennytm @hfxsd @purelind @ti-chi-bot @GMHDBJD