tools, toc: reorganize TiDB Binlog documents #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lilin90 @GregoryIan @csuzhangxc @WangXiangUSTC PTAL. |
IANTHEREAL
reviewed
Apr 29, 2019
IANTHEREAL
reviewed
Apr 29, 2019
IANTHEREAL
reviewed
Apr 29, 2019
IANTHEREAL
reviewed
Apr 29, 2019
|
structure is LGTM |
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
|
if there are too many content need to be adjusted, I think we can just refine the structure in this pr, and do others later @lilin90 |
lilin90
reviewed
Apr 29, 2019
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
lilin90
reviewed
May 1, 2019
LGTM Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
lilin90
reviewed
May 5, 2019
Co-Authored-By: ericsyh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's PR background.
The current tidb-binlog put everything in one page, which is not so friendly to users.
What had done in this PR.
I split the previous documents into the overview, deploy, upgrade, operation and monitor 5 parts.
To-do List
Add FAQ troubleshooting documents for Binlog
Binlog cluster scale up/down documents
And docs-cn PR link: pingcap/docs-cn#1264