sql: update the USE command explanation in util document #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilin90
reviewed
Apr 24, 2019
lilin90
changed the title
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
Co-Authored-By: ericsyh <[email protected]>
|
Suggestion LGTM. |
morgo
added a commit
that referenced
this pull request
Apr 29, 2019
* Convert English Docs to DITA ToC (#996) The content remains the same. Only the TOC changes in this PR * Fix a broken link (#1047) * tools: add more argument description of Syncer (#1030) * tools: add more argument description of syncer Via: pingcap/docs-cn#1215 * sql: add working mechanism of system variables (#1035) Via: pingcap/docs-cn#1225 PTAL * overview, intro: move content around (#1045) * Update TOC.md * Update and rename overview.md to key-features.md * Update and rename QUICKSTART.md to overview.md * Initial move of monitor/secure * TOC: fix breakage from #1045 (#1050) The features linked to overview.md * Sql/transaction: changes on variables (#1036) * tools, v2.1: fix a typo (#1052) * add blank line and fix incorrect link (#1051) * toc, config flags: fix inconsistencies in headings (#1054) * fix inconsistencies in file names and heading * use 2nd level heading for all flags * fix typo in meta * revert file name change until later * revert file name * escape * character * sql: update EXPLAIN related document (#1039) * fix the format error * Revert "fix the format error" This reverts commit 2855bbd. * sysbench-v4: fix a format error * sql: add and modify some contents * Revert "sysbench-v4: fix a format error" This reverts commit 2d9016c. * sql: update sql\EXPLAIN related documents * Update mysql-compatibility.md * correct one format error * Add homebrew and dbdeployer guides (#1056) * Add homebrew and dbdeployer guides * fix case * Update install-from-homebrew.md * fix tabs (#1058) Unfortunately I can't preview this, because the preview website has not updated in >2 hours. * benchmark: update wording (#1055) * benchmark: update wording * Remove "the" * Minor typo fix (#1061) * gsod: add TiDB project ideas (#1066) * gsod: add TiDB project ideas * gsod: update the file name and format * Small change to bash scripting for downloading bikeshare data files (#1063) Use curl instead of wget (more commonly available) * Change URL structure of how-to/get-started (#1046) Changed URL structure of how-to/get-started. Fixed s/sample/example/ bug introduced in DITA fixed categories * Attempt to fix relative link. (#1069) There seems to be a problem with the website in that the filename in the current directory is not relative. I am not sure if this will fix it, but I have to try, since including the full path (/dev/how-to/..) makes version split more difficult, since only one version will be /dev/. * tools, media: update binlog's config file (#1053) * tools, media: update binlog's config file * Update tools/tidb-binlog-cluster.md Co-Authored-By: IzabelWang <[email protected]> * Update tools/tidb-binlog-cluster.md Co-Authored-By: IzabelWang <[email protected]> * Update tools/tidb-binlog-cluster.md Co-Authored-By: IzabelWang <[email protected]> * Update tools/tidb-binlog-cluster.md Co-Authored-By: IzabelWang <[email protected]> * Update tools/tidb-binlog-cluster.md Co-Authored-By: IzabelWang <[email protected]> * Update tidb-binlog-cluster.md Add ”txn-batch = 20". * Update tidb-binlog-cluster.md Address a commit. * Update tidb-binlog-cluster.md Address a commit. * v2.1/tools: update TiDB-Binlog * Revert "v2.1/tools: update TiDB-Binlog" This reverts commit 60e49a5. * Update tools/tidb-binlog-cluster.md Co-Authored-By: IzabelWang <[email protected]> * v2.1/tools: update TiDB-Binlog (#1059) * v2.1/tools: update TiDB-Binlog * Update tidb-binlog-cluster.md Address a commit. * op-guide: update TiDB-Ansible version information (#1064) * Fix broken link using absolute reference (#1077) * Cleaned up and added TiDB Server info (#1076) * Cleaned up and added TiDB Server info * More doc cleanup * Fixed table of node mappings * Clarified command line parameters * Fixed letter casing and indenting * Clarified need to download binlogctl * update condition (#1072) * benchmark, v2.1/benchmark: remove an invalid link (#1080) * *: update the Note format (#1079) * *: update the Note format * Update note format * Update the Note format * ROADMAP: add supporting invisible index (#1070) * ROADMAP: add supporting invisible index 1. Add supporting invisible index 2. Fix a spelling mistake in line 45 * ROADMAP: add supporting invisible index * Update ROADMAP.md Co-Authored-By: IzabelWang <[email protected]> * sql, TOC: update doc title (#1071) * Update URLs for deploy (#1048) * Moved how-to/deply files to new URLs * Update URLs to use absolute links. * Update the rest of how-to files * fix missing toc updates * Fix missing file rename * sql: update the USE command explanation in util document (#1075) * docs-cn #1112 Update the USE command explanation in util document * Update sql/util.md Co-Authored-By: ericsyh <[email protected]> * Update v1.0/sql/util.md Co-Authored-By: ericsyh <[email protected]> * Update v2.0/sql/util.md Co-Authored-By: ericsyh <[email protected]> * Update v2.1/sql/util.md Co-Authored-By: ericsyh <[email protected]> * update the loader pprof-addr default port (#1065) * releases: correct the TiDB-Ansible version (#1084) * *: update the Warning format (#1082) * TOC: fix a broken link and update capitalization (#1090) * *: explain select for update statement (#1093) * *: explain select for update statement Via: pingcap/docs-cn#1284 * *: update wording * *: update description * *: update format and wording * tools: update syncer batch size (#1092) * trouble-shooting: update the issue report link (#1091) * trouble-shooting: update the issue report link * Update trouble-shooting.md Co-Authored-By: CaitinChen <[email protected]> * Update trouble-shooting.md Co-Authored-By: CaitinChen <[email protected]> * Update trouble-shooting.md Co-Authored-By: CaitinChen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR background
User provided feedback that our explanation of TiDB 'USE' command in util document is not quite accurate: the meaning of default database is confusing.
Detailed at the issue link: pingcap/docs-cn#1112
And the docs-cn PR link: pingcap/docs-cn#1269
What has done in the PR
I updated the explanation of TiDB 'USE' command in sql/util.md documents (1.0/2.0/2.1).
Previously: 'The USE statement is used to switch the default database. If the table in this SQL statement does not correspond to an explicitly specified database, then the default database is used.'
Updated: 'The
USEstatement is used to switch the default database. If the table in this SQL statement does not correspond to an explicitly specified database, then the current selected database will be used by default.'