Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-guide: differentiate requirement vs. recommend #1029

Merged
merged 1 commit into from
Apr 9, 2019
Merged

op-guide: differentiate requirement vs. recommend #1029

merged 1 commit into from
Apr 9, 2019

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Apr 9, 2019

Some parts of the requirements are really recommendations. We should make the language clearer, so someone does not think it won't work without this.

@morgo
Copy link
Contributor Author

morgo commented Apr 9, 2019

PTAL @kolbe @ceohockey60

ngaut
ngaut approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolbe kolbe merged commit 3a885a6 into master Apr 9, 2019
@kolbe kolbe deleted the morgo-requirements branch April 9, 2019 17:35
@huangxiuyan huangxiuyan mentioned this pull request Apr 10, 2019
Merged
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolbe kolbe kolbe approved these changes

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morgo @ngaut @kolbe @sre-bot