Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb-binlog: update kafka-max-message-size configuration #7445

Merged
merged 4 commits into from
Dec 6, 2021
Merged

tidb-binlog: update kafka-max-message-size configuration #7445

merged 4 commits into from
Dec 6, 2021

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Nov 9, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

update kafka-max-message-size configuration

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions) [This feature is cherry-pick but not released below this version]
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Liuxiaozhen12
  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn November 9, 2021 09:00
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2021
@TomShawn TomShawn requested review from amyangfei and glorv November 10, 2021 02:15
@TomShawn TomShawn added needs-cherry-pick-release-5.0 area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Nov 10, 2021
@TomShawn
Copy link
Contributor

/verify

@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label Nov 10, 2021
glorv
glorv reviewed Nov 10, 2021
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

tidb-binlog/deploy-tidb-binlog.md Outdated
@@ -358,6 +358,8 @@ Drainer="192.168.0.13"
# kafka-addrs = "127.0.0.1:9092"
# kafka-version = "0.8.2.0"
# kafka-max-messages = 1024
# 配置单条 Kafka 消息的最大 size（单位为 Byte），默认为 1 GB，最大可配置为 2 GB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 配置单条 Kafka 消息的最大 size（单位为 Byte），默认为 1 GB，最大可配置为 2 GB
# 配置单条 Kafka 消息的最大 size（单位为 Byte），默认为 1 GiB，最大可配置为 2 GiB

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, 最好给 kafka-max-messages 也加个注释

glorv
glorv reviewed Nov 10, 2021
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Liuxiaozhen12
Liuxiaozhen12 approved these changes Nov 11, 2021
View reviewed changes
tidb-binlog/deploy-tidb-binlog.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2021
@TomShawn TomShawn added the type/enhancement The issue or PR belongs to an enhancement. label Dec 2, 2021
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 6, 2021
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 6, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Dec 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c95117a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 6, 2021
@ti-chi-bot ti-chi-bot merged commit 5456268 into pingcap:master Dec 6, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 6, 2021
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7820.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 6, 2021
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7821.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 6, 2021
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7822.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 6, 2021
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7823.

TomShawn added a commit that referenced this pull request Dec 6, 2021
@ti-chi-bot @lichunzhu
@TomShawn @Liuxiaozhen12
tidb-binlog: update kafka-max-message-size configuration (#7445) (#7820)
aea0d64 
* update kafka-max-message-size

* Update tidb-binlog/deploy-tidb-binlog.md

* address comments

* Update tidb-binlog/deploy-tidb-binlog.md

Co-authored-by: Liuxiaozhen12 <[email protected]>

Co-authored-by: Chunzhu Li <[email protected]>
Co-authored-by: TomShawn <[email protected]>
Co-authored-by: Chunzhu Li <[email protected]>
Co-authored-by: Liuxiaozhen12 <[email protected]>
ti-chi-bot added a commit that referenced this pull request Dec 6, 2021
@ti-chi-bot
tidb-binlog: update kafka-max-message-size configuration (#7445) (#7822)
1c2a5b4
ti-chi-bot added a commit that referenced this pull request Dec 6, 2021
@ti-chi-bot
tidb-binlog: update kafka-max-message-size configuration (#7445) (#7821)
faa6f70
ti-chi-bot added a commit that referenced this pull request Dec 6, 2021
@ti-chi-bot
tidb-binlog: update kafka-max-message-size configuration (#7445) (#7823)
c9ecc2f
@shichun-0415 shichun-0415 mentioned this pull request Dec 13, 2021
Merged
14 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 13, 2021
This was referenced Dec 14, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv left review comments

@Liuxiaozhen12 Liuxiaozhen12 Liuxiaozhen12 approved these changes

@TomShawn TomShawn TomShawn approved these changes

@amyangfei amyangfei Awaiting requested review from amyangfei

Assignees

@shichun-0415 shichun-0415

Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lichunzhu @ti-chi-bot @TomShawn @glorv @Liuxiaozhen12 @shichun-0415