-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pd-control: update config of balance-hot-region-scheduler #6888
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@HunDunDM: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
pd-control.md
Outdated
@@ -1076,13 +1076,13 @@ Encoding 格式示例: | |||
>> scheduler config balance-hot-region-scheduler set src-tolerance-ratio 1.1 | |||
``` | |||
|
|||
- `read-priorities`、`write-leader-priorities`、`write-peer-priorities` 用于控制处理不同类型的热点时,优先均衡的第一维度和第二维度。对于 `read` 和 `write-leader` 类型的热点,可选的维度有 `query`、`byte` 和 `key`。对于 `write-peer` 类型的热点,可选的维度有 `byte` 和 `key`。若集群组件未全部升级到 v5.2 及以上版本,这些配置不会生效,固定使用兼容配置。通常用户不需要修改这些配置项。 | |||
- `read-priorities`、`write-leader-priorities`、`write-peer-priorities` 用于控制处理不同类型的热点时,优先均衡的第一维度和第二维度。对于 `read` 和 `write-leader` 类型的热点,可选的维度有 `query`、`byte` 和 `key`。对于 `write-peer` 类型的热点,可选的维度有 `byte` 和 `key`。若集群组件未全部升级到 v5.2 及以上版本,这些配置不会生效,固定使用兼容配置,升级完成后会继续保持兼容配置。兼容配置与新集群的默认配置的区别是不含有 `query` 维度。通常用户不需要修改这些配置项。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `read-priorities`、`write-leader-priorities`、`write-peer-priorities` 用于控制处理不同类型的热点时,优先均衡的第一维度和第二维度。对于 `read` 和 `write-leader` 类型的热点,可选的维度有 `query`、`byte` 和 `key`。对于 `write-peer` 类型的热点,可选的维度有 `byte` 和 `key`。若集群组件未全部升级到 v5.2 及以上版本,这些配置不会生效,固定使用兼容配置,升级完成后会继续保持兼容配置。兼容配置与新集群的默认配置的区别是不含有 `query` 维度。通常用户不需要修改这些配置项。 | |
- `read-priorities`、`write-leader-priorities`、`write-peer-priorities` 用于控制处理不同类型的热点时,优先均衡的第一维度和第二维度。对于 `read` 和 `write-leader` 类型的热点,可选的维度有 `query`、`byte` 和 `key`。对于 `write-peer` 类型的热点,可选的维度有 `byte` 和 `key`。若集群组件未全部升级到 v5.2 及以上版本,这些配置不会生效,固定使用兼容配置。集群组件全部升级完成后,会继续保持兼容配置。兼容配置与新集群的默认配置的区别是,兼容配置没有 `query` 维度。通常用户不需要修改这些配置项。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Grace Cai <[email protected]>
PTAL @qiancai @Liuxiaozhen12 |
Co-authored-by: Liuxiaozhen12 <[email protected]>
Co-authored-by: Liuxiaozhen12 <[email protected]>
pd-control.md
Outdated
- `read-priorities`、`write-leader-priorities` 和 `write-peer-priorities` 用于控制调度器优先从哪些维度进行热点均衡。 | ||
|
||
- `read-priorities` 和 `write-leader-priorities` 用于控制调度器在处理 read 和 write-leader 类型的热点时优先均衡的维度,支持配置两个维度。可选的维度有 `query`、`byte` 和 `key`。 | ||
- `write-peer-priorities` 用于控制调度器在处理 write-peer 类型的热点时优先均衡的维度,支持配置两个维度,支持配置 `byte` 和 `key` 维度。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `write-peer-priorities` 用于控制调度器在处理 write-peer 类型的热点时优先均衡的维度,支持配置两个维度,支持配置 `byte` 和 `key` 维度。 | |
- `write-peer-priorities` 用于控制调度器在处理 write-peer 类型的热点时优先均衡的维度,支持配置 `byte` 和 `key` 这两个维度。 |
Co-authored-by: Grace Cai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 750debb
|
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?