Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd-control: update config of balance-hot-region-scheduler #6888

Merged
merged 15 commits into from
Aug 20, 2021

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Aug 18, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lhy1024 lhy1024 requested review from Yisaer and HunDunDM August 18, 2021 08:54
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Liuxiaozhen12
  • Yisaer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2021
@TomShawn TomShawn added status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. v5.2 This PR/issue applies to TiDB v5.2. and removed missing-translation-status This PR does not have translation status info. labels Aug 19, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2021
@TomShawn TomShawn requested a review from qiancai August 19, 2021 06:11
@ti-chi-bot
Copy link
Member

@HunDunDM: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

pd-control.md Outdated
@@ -1076,13 +1076,13 @@ Encoding 格式示例:
>> scheduler config balance-hot-region-scheduler set src-tolerance-ratio 1.1
```

- `read-priorities`、`write-leader-priorities`、`write-peer-priorities` 用于控制处理不同类型的热点时,优先均衡的第一维度和第二维度。对于 `read` 和 `write-leader` 类型的热点,可选的维度有 `query`、`byte` 和 `key`。对于 `write-peer` 类型的热点,可选的维度有 `byte` 和 `key`。若集群组件未全部升级到 v5.2 及以上版本,这些配置不会生效,固定使用兼容配置。通常用户不需要修改这些配置项。
- `read-priorities`、`write-leader-priorities`、`write-peer-priorities` 用于控制处理不同类型的热点时,优先均衡的第一维度和第二维度。对于 `read` 和 `write-leader` 类型的热点,可选的维度有 `query`、`byte` 和 `key`。对于 `write-peer` 类型的热点,可选的维度有 `byte` 和 `key`。若集群组件未全部升级到 v5.2 及以上版本,这些配置不会生效,固定使用兼容配置,升级完成后会继续保持兼容配置。兼容配置与新集群的默认配置的区别是不含有 `query` 维度。通常用户不需要修改这些配置项。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `read-priorities``write-leader-priorities``write-peer-priorities` 用于控制处理不同类型的热点时,优先均衡的第一维度和第二维度。对于 `read``write-leader` 类型的热点,可选的维度有 `query``byte``key`。对于 `write-peer` 类型的热点,可选的维度有 `byte``key`。若集群组件未全部升级到 v5.2 及以上版本,这些配置不会生效,固定使用兼容配置,升级完成后会继续保持兼容配置。兼容配置与新集群的默认配置的区别是不含有 `query` 维度。通常用户不需要修改这些配置项。
- `read-priorities``write-leader-priorities``write-peer-priorities` 用于控制处理不同类型的热点时,优先均衡的第一维度和第二维度。对于 `read``write-leader` 类型的热点,可选的维度有 `query``byte``key`。对于 `write-peer` 类型的热点,可选的维度有 `byte``key`。若集群组件未全部升级到 v5.2 及以上版本,这些配置不会生效,固定使用兼容配置。集群组件全部升级完成后,会继续保持兼容配置。兼容配置与新集群的默认配置的区别是,兼容配置没有 `query` 维度。通常用户不需要修改这些配置项。

pd-control.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pd-control.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Aug 19, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2021
@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 19, 2021

PTAL @qiancai @Liuxiaozhen12

pd-control.md Outdated Show resolved Hide resolved
Co-authored-by: Liuxiaozhen12 <[email protected]>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 19, 2021
pd-control.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
pd-control.md Outdated
- `read-priorities`、`write-leader-priorities` 和 `write-peer-priorities` 用于控制调度器优先从哪些维度进行热点均衡。

- `read-priorities` 和 `write-leader-priorities` 用于控制调度器在处理 read 和 write-leader 类型的热点时优先均衡的维度,支持配置两个维度。可选的维度有 `query`、`byte` 和 `key`。
- `write-peer-priorities` 用于控制调度器在处理 write-peer 类型的热点时优先均衡的维度,支持配置两个维度,支持配置 `byte` 和 `key` 维度。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `write-peer-priorities` 用于控制调度器在处理 write-peer 类型的热点时优先均衡的维度,支持配置两个维度,支持配置 `byte` 和 `key` 维度
- `write-peer-priorities` 用于控制调度器在处理 write-peer 类型的热点时优先均衡的维度,支持配置 `byte` 和 `key` 这两个维度

pd-control.md Outdated Show resolved Hide resolved
@Liuxiaozhen12 Liuxiaozhen12 requested a review from qiancai August 20, 2021 03:39
@TomShawn TomShawn added the type/enhancement The issue or PR belongs to an enhancement. label Aug 20, 2021
pd-control.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Aug 20, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 750debb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 20, 2021
@ti-chi-bot ti-chi-bot merged commit 9097806 into master Aug 20, 2021
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 20, 2021
@TomShawn TomShawn deleted the lhy1024-patch-1 branch August 24, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement. v5.2 This PR/issue applies to TiDB v5.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants