tidb-in-kubernetes: add tidb and pump affinity configuration for prod best practice #2083

Yisaer · 2019-11-28T08:31:26Z

What is changed, added or deleted?

Add tidb and pump affinity configuration for prod best practice.

What is the related PR or file link(s)?

#2073

Which version does your change affect?

I will add it into v3.0 and v3.1 if I get 2 LGTM

dev

…m/Yisaer/docs-cn into add_pump_deployment_best_practice

dev/tidb-in-kubernetes/maintain/tidb-binlog.md

tennix · 2019-11-28T09:46:03Z

dev/tidb-in-kubernetes/maintain/tidb-binlog.md

+
+    默认情况下， TiDB 的 affinity 亲和性设置为 `{}`，当启用 TiDB Binlog 时，由于目前 Pump 组件与 TiDB 组件默认并不是一一对应的，如果当 Pump 与 TiDB 组件分开部署并出现网络隔离时并且 TiDB Binlog 还开启了 `ignore-error` 时，将会导致 TiDB 丢失 Binlog 。推荐通过亲和性特性将 TiDB 与 Pump 部署在同一台 Node 上，同时通过反亲和性特性将 Pump 分散在不同的 Node 上，每台 Node 上至多仅需一个 Pump 实例即可。
+
+    * 将 `tidb.affinity` 按照如下设置:


The affinity rules need to be restricted within a single tidb cluster.

Updated.

Add app.kubernetes.io/instance key to restricted into a single tidb cluster

Co-Authored-By: weekface <[email protected]>

dev/tidb-in-kubernetes/maintain/tidb-binlog.md

lilin90 · 2019-11-28T12:13:15Z

dev/tidb-in-kubernetes/maintain/tidb-binlog.md

+
+    * 将 `tidb.affinity` 按照如下设置:
+
+    ```yaml


Indent this code block with 4 more spaces to make it display well under the list item.

lilin90 · 2019-11-28T12:13:38Z

dev/tidb-in-kubernetes/maintain/tidb-binlog.md

+
+    * 将 `binlog.pump.affinity` 按照如下设置:
+
+    ```yaml


Indent this code block with 4 more spaces.

Co-Authored-By: Lilian Lee <[email protected]>

DanielZhangQD · 2019-11-29T02:17:29Z

dev/tidb-in-kubernetes/maintain/tidb-binlog.md

+
+    ```yaml
+    binlog:
+      pump:


Suggest configuring affinity with tidb too, in case that pump topology changed after the rolling update.

Tidb affinity already configured in the request.

I mean podaffinity for pump to colocate with tidb.

Co-Authored-By: Lilian Lee <[email protected]>

lilin90 · 2019-11-29T03:53:44Z

dev/tidb-in-kubernetes/maintain/tidb-binlog.md

+
+    * 将 `tidb.affinity` 按照如下设置：
+
+      ```yaml


Please indent this code block with 8 spaces ahead. Otherwise, it will cause display chaos at the PingCAP website (although now it displays well on GitHub). Thanks!

Suggested change

```yaml

```yaml

lilin90 · 2019-11-29T03:54:16Z

dev/tidb-in-kubernetes/maintain/tidb-binlog.md

+
+    * 将 `binlog.pump.affinity` 按照如下设置：
+
+      ```yaml


Indent this code block with 8 spaces from the beginning of each line.

lilin90

LGTM

lilin90 · 2019-11-29T05:37:28Z

@DanielZhangQD PTAL

tennix · 2019-11-29T08:06:38Z

dev/tidb-in-kubernetes/maintain/tidb-binlog.md

+                      - key: "app.kubernetes.io/instance"
+                        operator: In
+                        values:
+                          - <release-name>


Add a document for what is this? Because users may just copy and paste this yaml snippet.

Suggest changing this to cluster-name, many DBAs take it as something like v1.0.4.

Currently <release-name> is used in many places in tidb-in-kubernetes document. I think we should keep it same globally. Maybe we could add a note to explain what's <release-name> ? @tennix @DanielZhangQD

DanielZhangQD

LGTM

Yisaer · 2019-12-05T03:38:13Z

@lilin90 PATL

lilin90

Rest LGTM

lilin90 · 2019-12-09T03:02:38Z

dev/tidb-in-kubernetes/maintain/tidb-binlog.md

+
+    > **注意：**
+    >
+    > <release-name> 需要替换为目标 `tidb-cluster`的 helm release name


Suggested change

> <release-name> 需要替换为目标 `tidb-cluster`的 helm release name

> `<release-name>` 需要替换为目标 `tidb-cluster` 的 Helm release name。

lilin90 · 2019-12-09T03:05:32Z

v3.1/tidb-in-kubernetes/maintain/tidb-binlog.md

+
+    > **注意：**
+    >
+    > <release-name> 需要替换为目标 `tidb-cluster`的 helm release name


Suggested change

> <release-name> 需要替换为目标 `tidb-cluster`的 helm release name

> `<release-name>` 需要替换为目标 `tidb-cluster` 的 Helm release name。

lilin90 · 2019-12-09T03:05:53Z

v3.0/tidb-in-kubernetes/maintain/tidb-binlog.md

+
+    > **注意：**
+    >
+    > <release-name> 需要替换为目标 `tidb-cluster`的 helm release name


Suggested change

> <release-name> 需要替换为目标 `tidb-cluster`的 helm release name

> `<release-name>` 需要替换为目标 `tidb-cluster` 的 Helm release name。

lilin90

LGTM

Song Gao and others added 2 commits November 28, 2019 16:01

Update tidb-binlog.md

733ae9d

Merge branch 'master' into add_pump_deployment_best_practice

7bfda9b

Yisaer requested a review from tennix November 28, 2019 08:31

Song Gao added 2 commits November 28, 2019 16:38

fix lint

f053dc2

Merge branch 'add_pump_deployment_best_practice' of https://github.co…

a4aa5f6

…m/Yisaer/docs-cn into add_pump_deployment_best_practice

weekface reviewed Nov 28, 2019

View reviewed changes

dev/tidb-in-kubernetes/maintain/tidb-binlog.md Outdated Show resolved Hide resolved

tennix reviewed Nov 28, 2019

View reviewed changes

Yisaer and others added 3 commits November 28, 2019 18:48

Update dev/tidb-in-kubernetes/maintain/tidb-binlog.md

6699915

Co-Authored-By: weekface <[email protected]>

Update tidb-binlog.md

567c4b6

Update tidb-binlog.md

23888e8

Yisaer requested review from weekface and tennix November 28, 2019 11:06

lilin90 added translation/doing This PR’s assignee is translating this PR. tidb-in-k8s labels Nov 28, 2019

Merge branch 'master' into add_pump_deployment_best_practice

102177c

lilin90 reviewed Nov 28, 2019

View reviewed changes

lilin90 assigned junlan-zhang Nov 28, 2019

Yisaer and others added 2 commits November 28, 2019 20:19

Update dev/tidb-in-kubernetes/maintain/tidb-binlog.md

1c07881

Co-Authored-By: Lilian Lee <[email protected]>

Update dev/tidb-in-kubernetes/maintain/tidb-binlog.md

4c4781a

Co-Authored-By: Lilian Lee <[email protected]>

DanielZhangQD reviewed Nov 29, 2019

View reviewed changes

Yisaer and others added 5 commits November 29, 2019 10:29

Update dev/tidb-in-kubernetes/maintain/tidb-binlog.md

8249fb0

Co-Authored-By: Lilian Lee <[email protected]>

Merge branch 'master' into add_pump_deployment_best_practice

e2b8bb4

Update dev/tidb-in-kubernetes/maintain/tidb-binlog.md

1bf1e61

Co-Authored-By: Lilian Lee <[email protected]>

indent code block

230069b

fix lint

c6a5905

Yisaer requested review from lilin90 and DanielZhangQD November 29, 2019 03:43

lilin90 reviewed Nov 29, 2019

View reviewed changes

Update tidb-binlog.md

825d0fb

Yisaer requested a review from lilin90 November 29, 2019 03:59

lilin90 reviewed Nov 29, 2019

View reviewed changes

Yisaer requested a review from lilin90 November 29, 2019 04:57

tennix reviewed Nov 29, 2019

View reviewed changes

Yisaer and others added 4 commits December 2, 2019 17:30

Merge branch 'master' into add_pump_deployment_best_practice

d279924

Merge branch 'master' into add_pump_deployment_best_practice

ad59269

Update tidb-binlog.md

2ad2a67

Merge branch 'master' into add_pump_deployment_best_practice

320c003

DanielZhangQD approved these changes Dec 5, 2019

View reviewed changes

Yisaer and others added 2 commits December 5, 2019 11:32

Merge branch 'master' into add_pump_deployment_best_practice

446b33e

add affninty in v3.0 and v3.1

c16d424

lilin90 reviewed Dec 9, 2019

View reviewed changes

DanielZhangQD mentioned this pull request Dec 10, 2019

manually cherry picked affinity for tidb and pump pingcap/tidb-operator#1278

Merged

CaitinChen and others added 3 commits December 13, 2019 15:46

Merge branch 'master' into add_pump_deployment_best_practice

809256d

Merge branch 'master' into add_pump_deployment_best_practice

7029065

*: update format

2980060

lilin90 approved these changes Dec 16, 2019

View reviewed changes

lilin90 merged commit db6a7dd into pingcap:master Dec 16, 2019

lilin90 mentioned this pull request Dec 16, 2019

增加 Kubernetes 上 pump 部署最佳实践 #2073

Closed

lilin90 added the size/medium Changes of a medium size. label Dec 16, 2019

junlan-zhang mentioned this pull request Feb 20, 2020

tidb-in-kubernetes: add TiDB and Pump affinity config pingcap/docs#1823

Merged

12 tasks

junlan-zhang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tidb-in-kubernetes: add tidb and pump affinity configuration for prod best practice #2083

tidb-in-kubernetes: add tidb and pump affinity configuration for prod best practice #2083

Yisaer commented Nov 28, 2019

tennix Nov 28, 2019

Yisaer Nov 28, 2019 •

edited

Loading

lilin90 Nov 28, 2019

Yisaer Nov 29, 2019

lilin90 Nov 28, 2019

Yisaer Nov 29, 2019

DanielZhangQD Nov 29, 2019

Yisaer Nov 29, 2019

DanielZhangQD Nov 29, 2019

Yisaer Dec 2, 2019

lilin90 Nov 29, 2019

Yisaer Nov 29, 2019

lilin90 Nov 29, 2019

Yisaer Nov 29, 2019

lilin90 left a comment

lilin90 commented Nov 29, 2019

tennix Nov 29, 2019

DanielZhangQD Nov 29, 2019

Yisaer Dec 2, 2019

DanielZhangQD left a comment

Yisaer commented Dec 5, 2019

lilin90 left a comment

lilin90 Dec 9, 2019 •

edited

Loading

lilin90 Dec 9, 2019 •

edited

Loading

lilin90 Dec 9, 2019 •

edited

Loading

lilin90 left a comment


		默认情况下， TiDB 的 affinity 亲和性设置为 `{}`，当启用 TiDB Binlog 时，由于目前 Pump 组件与 TiDB 组件默认并不是一一对应的，如果当 Pump 与 TiDB 组件分开部署并出现网络隔离时并且 TiDB Binlog 还开启了 `ignore-error` 时，将会导致 TiDB 丢失 Binlog 。推荐通过亲和性特性将 TiDB 与 Pump 部署在同一台 Node 上，同时通过反亲和性特性将 Pump 分散在不同的 Node 上，每台 Node 上至多仅需一个 Pump 实例即可。

		* 将 `tidb.affinity` 按照如下设置:

	> <release-name> 需要替换为目标 `tidb-cluster`的 helm release name
	> `<release-name>` 需要替换为目标 `tidb-cluster` 的 Helm release name。

tidb-in-kubernetes: add tidb and pump affinity configuration for prod best practice #2083

tidb-in-kubernetes: add tidb and pump affinity configuration for prod best practice #2083

Conversation

Yisaer commented Nov 28, 2019

What is changed, added or deleted?

What is the related PR or file link(s)?

Which version does your change affect?

Choose a reason for hiding this comment

Yisaer Nov 28, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lilin90 left a comment

Choose a reason for hiding this comment

lilin90 commented Nov 29, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DanielZhangQD left a comment

Choose a reason for hiding this comment

Yisaer commented Dec 5, 2019

lilin90 left a comment

Choose a reason for hiding this comment

lilin90 Dec 9, 2019 • edited Loading

Choose a reason for hiding this comment

lilin90 Dec 9, 2019 • edited Loading

Choose a reason for hiding this comment

lilin90 Dec 9, 2019 • edited Loading

Choose a reason for hiding this comment

lilin90 left a comment

Choose a reason for hiding this comment

Yisaer Nov 28, 2019 •

edited

Loading

lilin90 Dec 9, 2019 •

edited

Loading

lilin90 Dec 9, 2019 •

edited

Loading

lilin90 Dec 9, 2019 •

edited

Loading