Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: update doc about ddl white list #19151

Merged
merged 45 commits into from
Jan 22, 2025
Merged

ticdc: update doc about ddl white list #19151

merged 45 commits into from
Jan 22, 2025

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Nov 22, 2024 •
edited by hfxsd
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2024
flowbehappy
flowbehappy reviewed Nov 22, 2024
View reviewed changes
flowbehappy
flowbehappy reviewed Nov 22, 2024
View reviewed changes
flowbehappy
flowbehappy reviewed Nov 22, 2024
View reviewed changes
flowbehappy
flowbehappy reviewed Nov 22, 2024
View reviewed changes
flowbehappy
flowbehappy reviewed Nov 22, 2024
View reviewed changes
flowbehappy
flowbehappy reviewed Nov 22, 2024
View reviewed changes
asddongmen
asddongmen reviewed Nov 22, 2024
View reviewed changes
lilin90
lilin90 reviewed Nov 25, 2024
View reviewed changes
ticdc/ticdc-ddl.md Outdated
- rebase auto id
- alter table index visibility
- exchange partition
- reorganize partition
- alter table ttl
- alter table remove ttl

> ***注意：**
Copy link
Member

@lilin90 lilin90 Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种“注意”的方式很少使用，是需要类似 TiDB 功能概览 | TiDB 文档中心的脚注吗？是的话，可以参考 https://github.com/pingcap/docs-cn/blob/master/basic-features.md 里的格式。

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2024
hfxsd
hfxsd reviewed Jan 22, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 22, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-21 08:59:46.274059399 +0000 UTC m=+171313.604978800: ☑️ agreed by qiancai.
  • 2025-01-22 06:22:11.99472952 +0000 UTC m=+248259.325648926: ☑️ agreed by hfxsd.

@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 22, 2025
hfxsd
hfxsd reviewed Jan 22, 2025
View reviewed changes
hfxsd
hfxsd reviewed Jan 22, 2025
View reviewed changes
@qiancai
Copy link
Collaborator

qiancai commented Jan 22, 2025

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jan 22, 2025
@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
qiancai
qiancai reviewed Jan 22, 2025
View reviewed changes
@qiancai
Copy link
Collaborator

qiancai commented Jan 22, 2025

/approve

@qiancai qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
@ti-chi-bot ti-chi-bot bot merged commit f975217 into pingcap:master Jan 22, 2025
7 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 22, 2025
@wk989898 @ti-chi-bot
ticdc: update doc about ddl white list (pingcap#19151)
039f16e
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19663.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2025
Merged
17 tasks
@qiancai qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
ticdc: update doc about ddl white list (#19151) (#19663)
112bb58
This was referenced Jan 22, 2025
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Jan 23, 2025
@ti-chi-bot
ticdc: update doc about ddl white list (#19151) (#19663) (#19665)
e0f5bd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@asddongmen asddongmen asddongmen approved these changes

@lilin90 lilin90 Awaiting requested review from lilin90

Assignees

@qiancai qiancai

Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wk989898 @qiancai @ti-chi-bot @flowbehappy @asddongmen @lilin90 @hfxsd