Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiflash: remove deprecated http_port #18868

Merged
merged 3 commits into from
Jan 20, 2025
Merged

tiflash: remove deprecated http_port #18868

merged 3 commits into from
Jan 20, 2025

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Oct 18, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

http_port has been deprecated since v7.1.0, remove all description about it.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2024
@Lloyd-Pottiger
Copy link
Contributor Author

/cc @JaySon-Huang

@ti-chi-bot ti-chi-bot bot requested a review from JaySon-Huang October 18, 2024 02:50
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2024

@zanmato1984: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Lloyd-Pottiger
address comments
db1aad8 
Signed-off-by: Lloyd-Pottiger <[email protected]>
JaySon-Huang
JaySon-Huang approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2024

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Oct 24, 2024
qiancai
qiancai reviewed Nov 8, 2024
View reviewed changes
enable-tls-between-components.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-topology-reference.md Outdated Show resolved Hide resolved
@qiancai qiancai added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 3, 2024
@qiancai
Copy link
Collaborator

qiancai commented Dec 30, 2024

Removed the needs-cherry-pick-release-8.2 label because the v8.2 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v8.2 and will no longer receive new updates.

@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jan 20, 2025
@qiancai
Copy link
Collaborator

qiancai commented Jan 20, 2025

/approve

@qiancai qiancai added the lgtm label Jan 20, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 20, 2025
@ti-chi-bot ti-chi-bot bot merged commit 3ebf0a9 into master Jan 20, 2025
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix-http-port branch January 20, 2025 09:41
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #19610.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 20, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #19611.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 20, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19612.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 20, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #19613.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 20, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19614.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 20, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19615.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 20, 2025
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 20, 2025
@ti-chi-bot
tiflash: remove deprecated http_port (#18868) (#19615)
d18d2fb
ti-chi-bot bot pushed a commit that referenced this pull request Jan 20, 2025
@ti-chi-bot
tiflash: remove deprecated http_port (#18868) (#19611)
df5bb7b
ti-chi-bot bot pushed a commit that referenced this pull request Jan 20, 2025
@ti-chi-bot
tiflash: remove deprecated http_port (#18868) (#19610)
c9f619e
ti-chi-bot bot pushed a commit that referenced this pull request Jan 20, 2025
@ti-chi-bot
tiflash: remove deprecated http_port (#18868) (#19612)
d1decb2
ti-chi-bot bot pushed a commit that referenced this pull request Jan 20, 2025
@ti-chi-bot
tiflash: remove deprecated http_port (#18868) (#19613)
c8a28bb
ti-chi-bot bot pushed a commit that referenced this pull request Jan 20, 2025
@ti-chi-bot
tiflash: remove deprecated http_port (#18868) (#19614)
7786659
@qiancai qiancai mentioned this pull request Jan 22, 2025
Merged
16 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 23, 2025
This was referenced Jan 23, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai left review comments

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lloyd-Pottiger @qiancai @ti-chi-bot @zanmato1984 @JaySon-Huang