Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference: add tidb session variable description about tidb_allow_remove_auto_inc #1858

Merged
merged 14 commits into from
Sep 17, 2019
Merged

reference: add tidb session variable description about tidb_allow_remove_auto_inc #1858

merged 14 commits into from
Sep 17, 2019

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Sep 12, 2019 •
edited
Loading

What is changed, added or deleted?

Add tidb session variable description about tidb_allow_remove_auto_inc.

What is the related PR or file link(s)?

master: pingcap/tidb#12107
release 2.1: pingcap/tidb#12146
release 3.0: pingcap/tidb#12145

Which version does your change affect?

dev, v2.1, v3.0

bb7133
bb7133 reviewed Sep 12, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update reference/mysql-compatibility.md as well

@tangenta tangenta requested review from bb7133 and winkyao September 16, 2019 01:51
yikeke
yikeke reviewed Sep 16, 2019
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments for v3.0 and v2.1

dev/reference/mysql-compatibility.md Outdated Show resolved Hide resolved
@yikeke yikeke added dev translation/doing This PR’s assignee is translating this PR. labels Sep 16, 2019
@tangenta tangenta requested review from bb7133 and yikeke September 16, 2019 08:44
yikeke
yikeke reviewed Sep 16, 2019
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

v2.1/reference/mysql-compatibility.md Outdated Show resolved Hide resolved
v3.0/reference/mysql-compatibility.md Outdated Show resolved Hide resolved
bb7133
bb7133 approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 17, 2019
@anotherrachel anotherrachel mentioned this pull request Sep 17, 2019
Merged
@bb7133 bb7133 merged commit fbefafe into pingcap:master Sep 17, 2019
@anotherrachel anotherrachel added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 17, 2019
@tangenta tangenta mentioned this pull request Sep 24, 2019
Merged
yikeke pushed a commit that referenced this pull request Sep 24, 2019
@yikeke
reference: fix inconsistent names in #1858 (#1892)
e5c1349 
* Update mysql-compatibility.md

* Update mysql-compatibility.md

* Update mysql-compatibility.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke left review comments

@bb7133 bb7133 bb7133 approved these changes

@winkyao winkyao Awaiting requested review from winkyao

Assignees

@anotherrachel anotherrachel

Labels
status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tangenta @bb7133 @winkyao @yikeke @anotherrachel