Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: rename how-to deploy files #1290

Closed
wants to merge 1 commit into from

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Apr 28, 2019

This PR renames all How-to Deploy files except "使用 Ansible 部署 DM 集群", because this file was not actually renamed in the corresponding docs PR (pingcap/docs#1048), and I wonder whether it's more appropriate to keep it in "tools/dm". It's weird to move only this file out.

@dcalvin @YiniXu9506 PTAL

Related PR: pingcap/docs#1048

@lilin90 lilin90 added the type/refactor The issue belongs to a refactor work. label Apr 28, 2019
@lilin90 lilin90 changed the title *: rename most how-to deploy files *: rename how-to deploy files Apr 28, 2019
Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90
Copy link
Member Author

lilin90 commented May 13, 2019

These changes are covered in #1321, so I'll close this PR.

@lilin90 lilin90 closed this May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/refactor The issue belongs to a refactor work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants