Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-guide: fix deployment about tidb-ansible version introduction #1238

Merged
merged 1 commit into from
Apr 16, 2019
Merged

op-guide: fix deployment about tidb-ansible version introduction #1238

merged 1 commit into from
Apr 16, 2019

Conversation

superlzs0476
Copy link
Contributor

@superlzs0476 superlzs0476 commented Apr 15, 2019 •
edited
Loading

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lilin90
Copy link
Member

lilin90 commented Apr 16, 2019

@superlzs0476 Please sign the CLA.

@lilin90 lilin90 changed the title Fix deployment about tidb-ansible version introduction. op-guide: fix deployment about tidb-ansible version introduction Apr 16, 2019
@superlzs0476
Copy link
Contributor Author

@superlzs0476 Please sign the CLA.

done

lilin90
lilin90 reviewed Apr 16, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90
Copy link
Member

lilin90 commented Apr 16, 2019

@liubo0127 PTAL

liubo0127
liubo0127 approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@liubo0127 liubo0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liubo0127 liubo0127 merged commit 56f0f22 into pingcap:master Apr 16, 2019
@CaitinChen CaitinChen mentioned this pull request Apr 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

@liubo0127 liubo0127 liubo0127 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@superlzs0476 @CLAassistant @lilin90 @liubo0127