Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools, media: update binlog's config file #1236

Merged
merged 9 commits into from
Apr 16, 2019
Merged

tools, media: update binlog's config file #1236

merged 9 commits into from
Apr 16, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Apr 15, 2019 •
edited
Loading

  1. sync-log
  2. grpc compressor
  3. sql-mode
  4. default value for txn-batch and worker-count
  5. ignore-table
  6. kafka topic-name
  7. remove TiFlash in architecture picture

@WangXiangUSTC WangXiangUSTC changed the title tools: update config file tools: update binlog's config file Apr 15, 2019
@lilin90 lilin90 requested a review from CaitinChen April 15, 2019 06:08
@lilin90 lilin90 changed the title tools: update binlog's config file tools, media: update binlog's config file Apr 15, 2019
lilin90
lilin90 reviewed Apr 15, 2019
View reviewed changes
tools/tidb-binlog-cluster.md Outdated Show resolved Hide resolved
tools/tidb-binlog-cluster.md Outdated Show resolved Hide resolved
tools/tidb-binlog-cluster.md Outdated Show resolved Hide resolved
tools/tidb-binlog-monitor.md Outdated Show resolved Hide resolved
@suzaku
Copy link
Contributor

suzaku commented Apr 16, 2019

LGTM

CaitinChen
CaitinChen approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaitinChen CaitinChen merged commit 34ec974 into pingcap:master Apr 16, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/update_binlog branch April 16, 2019 07:27
@IzabelWang IzabelWang mentioned this pull request Apr 16, 2019
Merged
@CaitinChen CaitinChen mentioned this pull request Apr 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

@CaitinChen CaitinChen CaitinChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WangXiangUSTC @suzaku @lilin90 @CaitinChen