Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: support create binding from existing plan #12187

Merged
merged 70 commits into from
Dec 28, 2022
Merged

planner: support create binding from existing plan #12187

merged 70 commits into from
Dec 28, 2022

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Dec 1, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2022
@ti-chi-bot ti-chi-bot requested a review from TomShawn December 1, 2022 13:17
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2022
@fzzf678 fzzf678 marked this pull request as ready for review December 2, 2022 08:56
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2022
qw4990
qw4990 reviewed Dec 6, 2022
View reviewed changes
sql-plan-management.md Outdated Show resolved Hide resolved
qw4990
qw4990 reviewed Dec 6, 2022
View reviewed changes
sql-plan-management.md Outdated Show resolved Hide resolved
qw4990
qw4990 reviewed Dec 6, 2022
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiancai qiancai self-assigned this Dec 6, 2022
@qiancai qiancai removed the request for review from TomShawn December 6, 2022 05:38
@qiancai qiancai added v6.5 This PR/issue applies to TiDB v6.5. translation/doing This PR’s assignee is translating this PR. labels Dec 6, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Dec 6, 2022
@qw4990 qw4990 added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2022
qw4990
qw4990 reviewed Dec 26, 2022
View reviewed changes
sql-plan-management.md Outdated Show resolved Hide resolved
qw4990
qw4990 reviewed Dec 26, 2022
View reviewed changes
sql-plan-management.md Outdated Show resolved Hide resolved
qw4990
qw4990 reviewed Dec 26, 2022
View reviewed changes
sql-statements/sql-statement-create-binding.md Outdated
@@ -29,6 +30,10 @@ BindableStmt ::=

## 示例

你可以根据 SQL hint 或历史执行计划创建绑定。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这边把 SQL hint 统一改成 SQL 或者 SQL 原文 好一点

qiancai
qiancai reviewed Dec 26, 2022
View reviewed changes
sql-plan-management.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Dec 26, 2022
View reviewed changes
sql-plan-management.md Outdated Show resolved Hide resolved
ran-huang
ran-huang reviewed Dec 26, 2022
View reviewed changes
sql-plan-management.md Outdated Show resolved Hide resolved
sql-plan-management.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 28, 2022
qiancai
qiancai approved these changes Dec 28, 2022
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 28, 2022
@qiancai
Copy link
Collaborator

qiancai commented Dec 28, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 14a4b54

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2022
@ti-chi-bot ti-chi-bot merged commit 4673e6d into pingcap:master Dec 28, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12445.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Dec 28, 2022
@fzzf678 @ti-chi-bot
planner: support create binding from existing plan (pingcap#12187)
3856587
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2022
Merged
15 tasks
ti-chi-bot added a commit that referenced this pull request Dec 28, 2022
@ti-chi-bot
planner: support create binding from existing plan (#12187) (#12445)
a3a73bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@qiancai qiancai qiancai approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees

@qiancai qiancai

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.5 This PR/issue applies to TiDB v6.5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fzzf678 @ti-chi-bot @qiancai @qw4990 @ran-huang @TomShawn