Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove arg -B in tiup #12048

Merged
merged 4 commits into from
Nov 18, 2022
Merged

remove arg -B in tiup #12048

merged 4 commits into from
Nov 18, 2022

Conversation

nexustar
Copy link
Contributor

@nexustar nexustar commented Nov 18, 2022 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

remove arg -B in TiUP

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn November 18, 2022 03:23
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2022
@Oreoxmt Oreoxmt added ONCALL Relates to documentation oncall. area/deploy-upgrade-maintain Indicates that the Issue or PR belongs to the area of deployment, upgrade, and maintenance. labels Nov 18, 2022
@Oreoxmt Oreoxmt self-assigned this Nov 18, 2022
@Oreoxmt Oreoxmt requested review from Oreoxmt and qqqdan and removed request for TomShawn November 18, 2022 03:42
@Oreoxmt Oreoxmt added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed missing-translation-status This PR does not have translation status info. labels Nov 18, 2022
@Oreoxmt Oreoxmt requested a review from shichun-0415 November 18, 2022 03:44
Oreoxmt
Oreoxmt approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2022
@Oreoxmt Oreoxmt added the type/bugfix This PR fixes a bug. label Nov 18, 2022
@Oreoxmt Oreoxmt mentioned this pull request Nov 18, 2022
Merged
15 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 18, 2022
shichun-0415
shichun-0415 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2022
@shichun-0415 shichun-0415 mentioned this pull request Nov 18, 2022
Closed
14 tasks
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 18, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cde1c4c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2022
@ti-chi-bot ti-chi-bot merged commit b002d20 into pingcap:master Nov 18, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12049.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12050.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12051.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12052.

This was referenced Nov 18, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12053.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12054.

ti-chi-bot added a commit that referenced this pull request Nov 18, 2022
@ti-chi-bot
remove arg -B in tiup (#12048) (#12053)
738f3a0
ti-chi-bot added a commit that referenced this pull request Nov 18, 2022
@ti-chi-bot
remove arg -B in tiup (#12048) (#12054)
d876601
This was referenced Nov 18, 2022
Merged
Merged
Merged
Merged
Merged
Merged
ti-chi-bot added a commit that referenced this pull request Nov 18, 2022
@ti-chi-bot
remove arg -B in tiup (#12048) (#12052)
b9b83ae
ti-chi-bot added a commit that referenced this pull request Nov 18, 2022
@ti-chi-bot
remove arg -B in tiup (#12048) (#12049)
1658681
ti-chi-bot added a commit that referenced this pull request Nov 18, 2022
@ti-chi-bot
remove arg -B in tiup (#12048) (#12050)
3a239f9
ti-chi-bot added a commit that referenced this pull request Nov 18, 2022
@ti-chi-bot
remove arg -B in tiup (#12048) (#12051)
7b65b92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qqqdan qqqdan qqqdan approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/deploy-upgrade-maintain Indicates that the Issue or PR belongs to the area of deployment, upgrade, and maintenance. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nexustar @ti-chi-bot @Oreoxmt @qqqdan @shichun-0415