Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-6.1] tiflash: Add instructions to improve replica sync performance #11653

Merged
merged 2 commits into from
Nov 3, 2022
Merged

[release-6.1] tiflash: Add instructions to improve replica sync performance #11653

merged 2 commits into from
Nov 3, 2022

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Oct 17, 2022 •
edited
Loading

Signed-off-by: Wish [email protected]

What is changed, added or deleted? (Required)

Add some instructions about how to sync TiFlash replica faster.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2022
@ti-chi-bot ti-chi-bot requested a review from TomShawn October 17, 2022 03:22
@breezewish breezewish changed the base branch from master to release-6.1 October 17, 2022 03:22
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 17, 2022
@shichun-0415 shichun-0415 self-assigned this Oct 17, 2022
@shichun-0415 shichun-0415 requested review from shichun-0415 and removed request for TomShawn October 17, 2022 03:44
@shichun-0415 shichun-0415 added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-5.0 area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed missing-translation-status This PR does not have translation status info. labels Oct 17, 2022
@breezewish
Polish
1124f68 
Signed-off-by: Wish <[email protected]>
shichun-0415
shichun-0415 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2022
@shichun-0415
Copy link
Contributor

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 2, 2022
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 3, 2022
@shichun-0415 shichun-0415 merged commit 04ba1bc into release-6.1 Nov 3, 2022
@shichun-0415 shichun-0415 deleted the wenxuan/r61-faster-tiflash-replica-sync branch November 3, 2022 06:09
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 3, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11868.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 3, 2022
@breezewish @ti-chi-bot
This is an automated cherry-pick of pingcap#11653
3c8d319 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 3, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11869.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 3, 2022
@breezewish @ti-chi-bot
This is an automated cherry-pick of pingcap#11653
f56d4a5 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 3, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11870.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 3, 2022
@breezewish @ti-chi-bot
This is an automated cherry-pick of pingcap#11653
2832f9b 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 3, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11871.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 3, 2022
@breezewish @ti-chi-bot
This is an automated cherry-pick of pingcap#11653
9dea13f 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 3, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11872.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 3, 2022
@breezewish @ti-chi-bot
This is an automated cherry-pick of pingcap#11653
61dcf63 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 3, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11873.

ti-chi-bot added a commit that referenced this pull request Nov 3, 2022
@ti-chi-bot
[release-6.3] tiflash: Add instructions to improve replica sync perfo…
7058a2d 
…rmance (#11653) (#11873)
@breezewish breezewish mentioned this pull request Nov 22, 2022
Merged
15 tasks
ti-chi-bot added a commit that referenced this pull request Nov 22, 2022
@ti-chi-bot
[release-5.0] tiflash: Add instructions to improve replica sync perfo…
f7dac35 
…rmance (#11653) (#11868)
ti-chi-bot added a commit that referenced this pull request Nov 22, 2022
@ti-chi-bot
[release-5.2] tiflash: Add instructions to improve replica sync perfo…
d8cb0d5 
…rmance (#11653) (#11870)
ti-chi-bot added a commit that referenced this pull request Nov 22, 2022
@ti-chi-bot
[release-5.1] tiflash: Add instructions to improve replica sync perfo…
0e3c185 
…rmance (#11653) (#11869)
ti-chi-bot added a commit that referenced this pull request Nov 22, 2022
@ti-chi-bot
[release-5.4] tiflash: Add instructions to improve replica sync perfo…
55d526c 
…rmance (#11653) (#11872)
ti-chi-bot added a commit that referenced this pull request Nov 22, 2022
@ti-chi-bot
[release-5.3] tiflash: Add instructions to improve replica sync perfo…
bdfbb84 
…rmance (#11653) (#11871)
@breezewish breezewish mentioned this pull request Nov 22, 2022
Merged
15 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

Assignees

@breezewish breezewish

Labels
area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@breezewish @ti-chi-bot @shichun-0415 @JaySon-Huang