-
Notifications
You must be signed in to change notification settings - Fork 188
syncer: add detect server version for upstream and downstream database #1673
syncer: add detect server version for upstream and downstream database #1673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
return | ||
} | ||
dctx := dcontext.NewContext(tctx.Ctx, logger) | ||
export.ParseServerInfo(dctx, versionInfo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems GetFlavor
and (*SourceConfig).AdjustFlavor
could be replaced by this function 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these two are different functions and we don't need to change them for now.
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1ca2968
|
In response to a cherrypick label: new pull request created: #1693. |
What problem does this PR solve?
DM didn't detect and print the versions for the upstream and downstream databases.
What is changed and how it works?
Add detect server version for syncer before we start the subtask.
Check List
Tests
Start a subtask and check the dm-worker's log:
Related changes